Fix validator set diff tests #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Jul 20, 2023
| @@ -189,7 +189,7 @@ func TestGetValidatorsSetProperty(t *testing.T) { | |||
| return fmt.Sprintf("failed GetValidatorSet: %s", err.Error()) | |||
| } | |||
| if !reflect.DeepEqual(validatorsSet, res) { | |||
| return fmt.Sprintf("failed validators set comparison: %s", err.Error()) | |||
There was a problem hiding this comment.
err is nil here - so this used to panic.
| return database.ErrNotFound | ||
| } | ||
| if val.PublicKey != expectedBlsKey { |
There was a problem hiding this comment.
This check assumes that the PublicKey pointer is equal, not the actual public key... Which means this is requiring the key to have been cached and not re-parsed.
darioush
approved these changes
Jul 20, 2023
samliok
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Some of the validator set diff tests currently act unexpectedly.
Refactored out of #1611.
How this works
Fixes the tests
How this was tested
Running the tests