Remove deprecated configs #1712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need a new ANR release to fix those tests. |
ramilexe
pushed a commit
to ConsiderItDone/avalanchego
that referenced
this pull request
Jul 14, 2023
Co-authored-by: Dan Laine <daniel.laine@avalabs.org> Co-authored-by: Stephen <stephen@avalabs.org>
StephenButtolph
approved these changes
Jul 20, 2023
joshua-kim
reviewed
Jul 20, 2023
| @@ -1509,12 +1485,3 @@ func providedFlags(v *viper.Viper) map[string]interface{} { | |||
| } | |||
| return customSettings | |||
| } | |||
|
|
|||
| // getRenamedKey returns the new key if it is set, otherwise it returns the deprecated key. | |||
| func getRenamedKey(v *viper.Viper, deprecatedKey string, newKey string) string { | |||
There was a problem hiding this comment.
This might be still useful to keep around if we deprecate keys in the future
There was a problem hiding this comment.
I think it would fail linting as dead code
| @@ -14,7 +14,7 @@ AVALANCHE_PATH=$( | |||
| # https://github.com/ava-labs/avalanche-network-runner | |||
| GOARCH=$(go env GOARCH) | |||
| GOOS=$(go env GOOS) | |||
| NETWORK_RUNNER_VERSION=1.3.9 | |||
There was a problem hiding this comment.
Why is this in the diff?
There was a problem hiding this comment.
The older ANR versions used the deprecated genesis key.
dhrubabasu
approved these changes
Jul 20, 2023
abi87
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes deprecated flags, which were deprecated for ~2 months
How this works
Removes deprecated flags from keys and configs.
How this was documented
ava-labs/builders-hub#1450