Skip to content

Update warp msg format #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 18, 2023
Merged

Update warp msg format #1686

merged 7 commits into from
Jul 18, 2023

Conversation

aaronbuchwald
Copy link
Collaborator

@aaronbuchwald aaronbuchwald commented Jul 3, 2023 •
edited
Loading

Why this should be merged

Addresses #1682

How this works

  • Deletes destinationChainID from warp message
  • Adds networkID

How this was tested

CI

@aaronbuchwald aaronbuchwald changed the base branch from master to dev July 3, 2023 19:46
@aaronbuchwald aaronbuchwald force-pushed the update-warp-msg-format branch from 886b90e to a7815e2 Compare July 13, 2023 14:13
ramilexe pushed a commit to ConsiderItDone/avalanchego that referenced this pull request Jul 14, 2023
@StephenButtolph
Remove ancient AWS spin up script (ava-labs#1686)
cee88d6
@aaronbuchwald aaronbuchwald marked this pull request as ready for review July 14, 2023 18:11
@aaronbuchwald aaronbuchwald self-assigned this Jul 17, 2023
@patrick-ogrady
Copy link
Contributor

If we add NetworkID, I think AvalancheGo should verify it is correct during Verify (and maybe Sign).

@aaronbuchwald
Copy link
Collaborator Author

If we add NetworkID, I think AvalancheGo should verify it is correct during Verify (and maybe Sign).

Ya I should have added this. I did a find and replace from destinationChainID to networkID and should have thought of the semantic difference we need to enforce.

@aaronbuchwald aaronbuchwald marked this pull request as draft July 18, 2023 15:07
@aaronbuchwald aaronbuchwald marked this pull request as ready for review July 18, 2023 15:52
@StephenButtolph StephenButtolph added this to the v1.10.5 milestone Jul 18, 2023
@StephenButtolph StephenButtolph merged commit 67df0d3 into dev Jul 18, 2023
@StephenButtolph StephenButtolph deleted the update-warp-msg-format branch July 18, 2023 18:08
@aaronbuchwald aaronbuchwald mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darioush darioush darioush approved these changes

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@abi87 abi87 Awaiting requested review from abi87

@danlaine danlaine Awaiting requested review from danlaine

@gyuho gyuho Awaiting requested review from gyuho

@hexfusion hexfusion Awaiting requested review from hexfusion

Assignees

@aaronbuchwald aaronbuchwald

Labels
warp
Projects
No open projects
Ski Patrol
Archived in project
Milestone
v1.10.5
Development

Successfully merging this pull request may close these issues.
4 participants
@aaronbuchwald @patrick-ogrady @darioush @StephenButtolph