Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetTx from the DAGVM interface #1642

Merged
merged 28 commits into from
Jun 22, 2023
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
36988a4
Remove DAG based tx issuance logic
StephenButtolph Jun 19, 2023
f4ae592
Remove dagState and GetUTXOFromID
StephenButtolph Jun 19, 2023
d924932
Fix unit tests
StephenButtolph Jun 19, 2023
7d1dda4
Merge branch 'remove-get-utxo-from-id' into remove-avm-tx-batcher
StephenButtolph Jun 19, 2023
4855439
wip make tests compile
StephenButtolph Jun 19, 2023
c517ea9
nit lint
StephenButtolph Jun 20, 2023
30485cd
fix linting
StephenButtolph Jun 20, 2023
4bc87bd
Merge branch 'dev' into remove-get-utxo-from-id
StephenButtolph Jun 20, 2023
2ff0186
wip cleanup tests
StephenButtolph Jun 20, 2023
23c038d
Merge branch 'remove-get-utxo-from-id' into remove-avm-tx-batcher
StephenButtolph Jun 20, 2023
ad086ba
wip fixup service tests
StephenButtolph Jun 20, 2023
724d878
more cleanup
StephenButtolph Jun 20, 2023
26f86e0
fix tests
StephenButtolph Jun 21, 2023
97950f1
keep test
StephenButtolph Jun 21, 2023
4c2e286
nit
StephenButtolph Jun 21, 2023
168aed9
nit
StephenButtolph Jun 21, 2023
b03a622
nits
StephenButtolph Jun 21, 2023
e4aa1c9
Remove PendingTxs from the DAGVM interface
StephenButtolph Jun 21, 2023
fc2df6e
lint
StephenButtolph Jun 21, 2023
37ae15c
Remove GetTx from the DAGVM interface
StephenButtolph Jun 21, 2023
9ad9511
lint
StephenButtolph Jun 21, 2023
3db4590
clenaup
StephenButtolph Jun 21, 2023
ca82e41
remove code changes
StephenButtolph Jun 21, 2023
208c7d9
merged
StephenButtolph Jun 21, 2023
55d91dc
merged
StephenButtolph Jun 21, 2023
c4838d8
Merge branch 'remove-pending-txs' into remove-get-tx
StephenButtolph Jun 21, 2023
c512d15
oops
StephenButtolph Jun 21, 2023
cc9f8fe
merged
StephenButtolph Jun 22, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
oops
  • Loading branch information
StephenButtolph committed Jun 21, 2023
commit c512d15e31b9a25b8cf37cf591516f41ad6cb63f
10 changes: 0 additions & 10 deletions vms/avm/vm.go
Original file line number Diff line number Diff line change
Expand Up @@ -480,16 +480,6 @@ func (vm *VM) ParseTx(_ context.Context, bytes []byte) (snowstorm.Tx, error) {
return tx, nil
}

func (vm *VM) GetTx(_ context.Context, txID ids.ID) (snowstorm.Tx, error) {
tx := &UniqueTx{
vm: vm,
txID: txID,
}
// Verify must be called in the case the that tx was flushed from the unique
// cache.
return tx, tx.verifyWithoutCacheWrites()
}

/*
******************************************************************************
********************************** JSON API **********************************
Expand Down