Pchain bls diffs fix cleanup #1594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Jun 7, 2023
Comment on lines
+139
to
+145
| lastAcceptedHeight, err := m.GetCurrentHeight(ctx) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if lastAcceptedHeight < height { | ||
| return nil, database.ErrNotFound | ||
| } |
There was a problem hiding this comment.
Kinda wish we didn't need to call this if the validator set was cached.... But this block should always be cached.
StephenButtolph
commented
Jun 7, 2023
| ) error { | ||
| targetWeightDiffs, err := m.state.GetValidatorWeightDiffs(height, subnetID) | ||
| // Get the public keys for all the validators at [targetHeight] | ||
| primarySet, err := m.getValidatorSetFrom(currentHeight, targetHeight, constants.PrimaryNetworkID) |
There was a problem hiding this comment.
Note: we don't call makePrimaryNetworkValidatorSet because it may be cached. This does result in tracking another lookup in the metrics, but I feel like that's fine.
abi87
approved these changes
Jun 8, 2023
hexfusion
pushed a commit
to hexfusion/avalanchego
that referenced
this pull request
Jun 22, 2023
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
currentHeight == targetHeightfor subnet BLS key trackingHow this works
Kept the majority of the code - just restructured it to be more efficient + have less edge cases.
How this was tested
CI