Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sync -- Use proto for sending Change Proofs #1541

Merged
merged 91 commits into from
Jun 1, 2023
Merged
Changes from 4 commits
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
d6426bf
Update sync.proto
dboehm-avalabs May 3, 2023
51e75d8
Update sync.proto
dboehm-avalabs May 3, 2023
dd74d3b
Update sync.proto
dboehm-avalabs May 3, 2023
b3b68ff
sync.proto recommended changes
rkuris May 3, 2023
f1eb6de
Review comments
rkuris May 4, 2023
6cce0d3
rename KeyProof to ProofNode; rename ProofNode.value_hash to ProofNod…
May 18, 2023
ec51aeb
actually add SerializedPath message
May 18, 2023
63386d4
int --> uint32 in proto
May 19, 2023
e108976
regenerate .pb.go files
May 19, 2023
7845dfd
Merge remote-tracking branch 'upstream/dev' into MerkleSyncProtos
May 19, 2023
d04c7a1
Merge branch 'MerkleSyncProtos' into MerkleSyncProtos-use-proto
May 19, 2023
dfe894d
add ToProto for ProofNode and RangeProof; send range proof repsonse a…
May 19, 2023
5af51ac
add FromProto for ProofNode; add tests
May 19, 2023
42422d1
add tests; add proto MaybeBytes type
May 19, 2023
35267b5
add proto MaybeBytes type
May 22, 2023
0d08f96
Merge branch 'MerkleSyncProtos' into MerkleSyncProtos-use-proto
May 22, 2023
ef94cf1
add to test
May 22, 2023
860ee03
disallow maybe with nothing and value
May 22, 2023
b3d3387
add comment
May 22, 2023
70e4ab4
add more proofNode validity checks
May 22, 2023
c0b2bdc
remove EncodeRangeProof and DecodeRangeProof
May 22, 2023
6dae5b5
Merge remote-tracking branch 'upstream/dev' into MerkleSyncProtos
May 22, 2023
e0f48b7
remove unused functions
May 22, 2023
7c1eb7c
import nits
May 22, 2023
e493c27
Merge branch 'MerkleSyncProtos' into MerkleSyncProtos-use-proto
May 22, 2023
d33831f
make value in MaybeBytes non-optional; make value in KeyChange a Mayb…
May 22, 2023
3d6b53a
Merge branch 'MerkleSyncProtos' into MerkleSyncProtos-use-proto
May 22, 2023
a47ad58
regenerate .pb.go files
May 22, 2023
8176dc3
add ToProto and UnmarshalProto for ChangeProof
May 22, 2023
ac38726
use proto to encode/decode change proofs
May 22, 2023
687e38f
WIP removing EncodeChangeProof and DecodeChangeProof usage
May 22, 2023
2859a54
add had_roots_in_history to ChangeProof
May 22, 2023
44f869c
Merge branch 'MerkleSyncProtos' into MerkleSyncProtos-use-proto-chang…
May 22, 2023
5f29b57
Merge branch 'MerkleSyncProtos-use-proto' of github.com:ava-labs/aval…
May 22, 2023
1115354
Merge branch 'MerkleSyncProtos-use-proto' of github.com:ava-labs/aval…
May 22, 2023
f2f50e2
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 22, 2023
d0cde74
Merge branch 'MerkleSyncProtos' into MerkleSyncProtos-use-proto
May 22, 2023
d6daa7b
fix proto ordering
May 22, 2023
4d47288
Merge branch 'MerkleSyncProtos' into MerkleSyncProtos-use-proto
May 22, 2023
94b03a0
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 22, 2023
35fbcec
update .pb.go files
May 22, 2023
3a0317c
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 22, 2023
93179cd
fix test
May 22, 2023
de32cda
comment nit
May 22, 2023
86a1b63
Merge branch 'MerkleSyncProtos' into MerkleSyncProtos-use-proto
May 22, 2023
a1da8f7
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 22, 2023
844d032
appease linter
May 22, 2023
73bcfd0
/* --> // for proto comments
May 23, 2023
7b434ea
Merge remote-tracking branch 'upstream/dev' into MerkleSyncProtos
May 23, 2023
4dffa64
Merge branch 'MerkleSyncProtos' into MerkleSyncProtos-use-proto
May 23, 2023
f9adebc
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 23, 2023
72b748c
/* --> // for proto comments
May 23, 2023
bb98fc5
Merge branch 'MerkleSyncProtos' into MerkleSyncProtos-use-proto
May 23, 2023
3149d41
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 23, 2023
f7d39a7
nit
May 23, 2023
07ade20
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 23, 2023
0524de5
Merge branch 'dev' into MerkleSyncProtos
May 24, 2023
0050f21
Merge remote-tracking branch 'upstream/dev' into MerkleSyncProtos
May 24, 2023
c99236d
Merge branch 'MerkleSyncProtos' of github.com:ava-labs/avalanchego in…
May 24, 2023
61f4c27
Merge branch 'MerkleSyncProtos' into MerkleSyncProtos-use-proto
May 24, 2023
081ab36
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 24, 2023
cad3a80
rename RangeProofResponse --> RangeProof
May 24, 2023
52af5a6
Merge branch 'MerkleSyncProtos' into MerkleSyncProtos-use-proto
May 24, 2023
4417a28
update .pb.go files
May 24, 2023
88d1495
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 24, 2023
f0c7833
Merge remote-tracking branch 'upstream/dev' into MerkleSyncProtos-use…
May 25, 2023
46baa78
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 25, 2023
c2d6692
add nil checks in ProofNode.UnmarshalProto
May 25, 2023
c19fbf8
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 25, 2023
78da8e0
Merge remote-tracking branch 'upstream/dev' into MerkleSyncProtos-use…
May 25, 2023
a62321c
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 25, 2023
be0f6bd
add nil checks in RangeProof.UnmarshalProto
May 25, 2023
dbd0714
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 25, 2023
4283af2
add nil checks in ChangeProof.UnmarshalProto
May 25, 2023
e5ad19b
`x/sync` -- Remove `EncodeProof`, `DecodeProof`, helpers (#1546)
May 30, 2023
d05f98c
Merge remote-tracking branch 'upstream/dev' into MerkleSyncProtos-use…
May 30, 2023
dfea9e5
change nibble length field from uint32 to uint64
May 30, 2023
137f75f
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 30, 2023
22a91c8
Merge branch 'MerkleSyncProtos-use-proto-change-proof' of github.com:…
May 30, 2023
cea0f50
import nit
May 30, 2023
57bfa1e
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 30, 2023
9022216
appease linter
May 30, 2023
e405154
Merge branch 'MerkleSyncProtos-use-proto' into MerkleSyncProtos-use-p…
May 30, 2023
a3109e3
appease linter
May 30, 2023
527785e
appease linter
May 30, 2023
6e6abd4
Merge remote-tracking branch 'upstream/dev' into MerkleSyncProtos-use…
May 31, 2023
9c19993
unexport codec methods
May 31, 2023
24f04e5
Merge remote-tracking branch 'upstream/dev' into MerkleSyncProtos-use…
May 31, 2023
31f6420
Merge branch 'dev' into MerkleSyncProtos-use-proto-change-proof
Jun 1, 2023
9431d52
Merge remote-tracking branch 'upstream/dev' into MerkleSyncProtos-use…
Jun 1, 2023
e684663
Merge branch 'MerkleSyncProtos-use-proto-change-proof' of github.com:…
Jun 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions proto/sync/sync.proto
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ message RangeProofResponse {
the use of KeyChange instead of KeyValue) */
message ChangeProof {
bool had_roots_in_history = 1; // TODO remove
repeated ProofNode start_proof = 1;
repeated ProofNode end_proof = 2;
repeated KeyChange key_changes = 3;
repeated ProofNode start_proof = 2;
repeated ProofNode end_proof = 3;
repeated KeyChange key_changes = 4;
}

/* ChangeProofResponse is the response for a ChangeProofRequest */
Expand Down