Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment referencing old IP based tracking #1509

Merged
merged 2 commits into from
May 17, 2023
Merged

Remove comment referencing old IP based tracking #1509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f74c407
Remove comment referencing old IP based tracking
StephenButtolph May 16, 2023
421fca3
Merge branch 'dev' into remove-out-of-date-comment
May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions network/network.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,13 +746,6 @@ func (n *network) Dispatch() error {
// Note: listener.Accept is rate limited outside of this package, so a
// peer can not just arbitrarily spin up goroutines here.
go func() {
// We pessimistically drop an incoming connection if the remote
// address is found in connectedIPs, myIPs, or peerAliasIPs. This
// protects our node from spending CPU cycles on TLS handshakes to
// upgrade connections from existing peers. Specifically, this can
// occur when one of our existing peers attempts to connect to one
// our IP aliases (that they aren't yet aware is an alias).
//
// Note: Calling [RemoteAddr] with the Proxy protocol enabled may
// block for up to ProxyReadHeaderTimeout. Therefore, we ensure to
// call this function inside the go-routine, rather than the main
Expand Down