Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve snow/ tests with require #1503

Merged
merged 98 commits into from
Jun 15, 2023
Merged
Changes from 5 commits
Commits
Show all changes
98 commits
Select commit Hold shift + click to select a range
a2771ba
ban `require.Equal` when testing for `0`
dhrubabasu May 12, 2023
88f6841
Merge branch 'dev' into ban-require-equal-zero
dhrubabasu May 12, 2023
b065a98
ban usage of `require.Zero` when testing for length `0`
dhrubabasu May 12, 2023
0ccf063
Merge branch 'ban-require-equal-zero' into ban-require-zero-len
dhrubabasu May 12, 2023
fd714b1
add failing test
dhrubabasu May 12, 2023
d4d925b
fix
dhrubabasu May 12, 2023
e961d37
nit
dhrubabasu May 12, 2023
7aab521
Merge branch 'ban-require-zero-len' into ban-require-equal-len
dhrubabasu May 12, 2023
cfd7ca0
push
dhrubabasu May 12, 2023
946588a
ban usage of `nil` in require functions
dhrubabasu May 12, 2023
5fcf0f0
nit
dhrubabasu May 12, 2023
10dff95
fix regex
dhrubabasu May 12, 2023
9fdc7c5
nit
dhrubabasu May 12, 2023
c343bc9
Merge branch 'dev' into ban-require-equal-zero
StephenButtolph May 12, 2023
3dbdab1
merged
dhrubabasu May 12, 2023
5530818
Merge branch 'ban-require-zero-len' into ban-require-equal-len
dhrubabasu May 12, 2023
6b2a170
Merge branch 'ban-require-equal-len' into ban-require-nil
dhrubabasu May 12, 2023
421b72d
add comment
dhrubabasu May 12, 2023
0c919fd
match uint(0)
dhrubabasu May 12, 2023
f8c4359
Update scripts/lint.sh
dhrubabasu May 12, 2023
df6b971
Merge branch 'ban-require-equal-zero' into ban-require-zero-len
dhrubabasu May 12, 2023
4a37e01
merged
dhrubabasu May 12, 2023
7e40d38
nit
dhrubabasu May 12, 2023
fb10a1a
pr review
dhrubabasu May 12, 2023
7aadaf4
revert
dhrubabasu May 12, 2023
af4382d
nit
dhrubabasu May 12, 2023
5301a7d
nits
dhrubabasu May 12, 2023
e249d2b
reduce diff
dhrubabasu May 12, 2023
be82305
reduce diff
dhrubabasu May 12, 2023
8aa012d
reduce diff
dhrubabasu May 12, 2023
24fb051
nit
dhrubabasu May 12, 2023
7de1858
Merge branch 'ban-require-equal-len' into ban-require-nil
dhrubabasu May 12, 2023
dfeb84b
more nil checks
dhrubabasu May 12, 2023
7901762
wording
dhrubabasu May 12, 2023
2f1ba2d
regex nit
dhrubabasu May 12, 2023
90b376e
Merge branch 'ban-require-equal-len' into ban-require-nil
dhrubabasu May 12, 2023
4680df5
add linter
dhrubabasu May 13, 2023
e967771
fix
dhrubabasu May 13, 2023
ff94591
fix regex
dhrubabasu May 13, 2023
0aa2d36
moar
dhrubabasu May 13, 2023
720bfb0
nit
dhrubabasu May 13, 2023
b71ff1c
include multi-line functions
dhrubabasu May 13, 2023
31e4a37
should be good now
dhrubabasu May 13, 2023
c7226cf
moar
dhrubabasu May 13, 2023
e48fbb5
nit
dhrubabasu May 13, 2023
9de4464
add linter
dhrubabasu May 13, 2023
a81f769
fix
dhrubabasu May 13, 2023
488d1a8
nit
dhrubabasu May 13, 2023
f17e674
fix
dhrubabasu May 13, 2023
c375007
Merge branch 'enforce-require-no-error-inline' into ban-require-equal…
dhrubabasu May 13, 2023
52f623e
Update scripts/lint.sh
dhrubabasu May 13, 2023
b30352c
nit
dhrubabasu May 13, 2023
a96a2d1
fix regex
dhrubabasu May 13, 2023
f07c5aa
Merge branch 'enforce-require-no-error-inline' into ban-require-equal…
dhrubabasu May 13, 2023
c7d6c75
Improve `snow/` tests with `require`
dhrubabasu May 13, 2023
411d3fb
Merge branch 'ban-require-equal-error' into testing-snow
dhrubabasu May 14, 2023
e436605
nits
dhrubabasu May 14, 2023
b8bd341
Merge branch 'ban-require-equal-error' into testing-snow
dhrubabasu May 14, 2023
b4aa566
nit
dhrubabasu May 14, 2023
f792b36
Merge branch 'ban-require-equal-error' into testing-snow
dhrubabasu May 14, 2023
689082f
nit
dhrubabasu May 14, 2023
0f6a4ad
Merge branch 'ban-require-equal-error' into testing-snow
dhrubabasu May 14, 2023
31fa556
merged
dhrubabasu May 15, 2023
5e3745a
Merge branch 'ban-require-zero-len' into ban-require-equal-len
StephenButtolph May 15, 2023
6709b1c
Update scripts/lint.sh
dhrubabasu May 16, 2023
5d2f1e2
Update scripts/lint.sh
dhrubabasu May 16, 2023
0457148
Merge branch 'dev' into ban-require-zero-len
dhrubabasu May 16, 2023
f4f0c15
nit
dhrubabasu May 16, 2023
8fb3d2a
increase negative diff woooooo
dhrubabasu May 16, 2023
62d168e
nit
dhrubabasu May 16, 2023
e7cf371
regex is easy they said
dhrubabasu May 16, 2023
b9d80b3
revert regex changes
dhrubabasu May 16, 2023
d1d0fdc
revert window change
dhrubabasu May 16, 2023
38e5742
nit
dhrubabasu May 16, 2023
a4bca48
Merge branch 'dev' into ban-require-zero-len
dhrubabasu May 16, 2023
f824d68
Merge branch 'ban-require-zero-len' into ban-require-equal-len
dhrubabasu May 16, 2023
adf3e39
Merge branch 'ban-require-equal-len' into ban-require-nil
dhrubabasu May 16, 2023
b58df9d
merged
dhrubabasu May 16, 2023
b93c523
reduce diff
dhrubabasu May 16, 2023
3402670
merged
dhrubabasu May 17, 2023
674f4d4
Merge branch 'enforce-require-no-error-inline' into ban-require-equal…
dhrubabasu May 17, 2023
6e6dbc2
Merge branch 'ban-require-equal-error' into testing-snow
dhrubabasu May 17, 2023
51b303b
Merge branch 'dev' into enforce-require-no-error-inline
dhrubabasu May 18, 2023
00c95dd
Merge branch 'enforce-require-no-error-inline' into ban-require-equal…
dhrubabasu May 18, 2023
2a0294b
merged
dhrubabasu May 18, 2023
3d0b39f
merged
dhrubabasu Jun 12, 2023
41e92b7
revert non-snow changes
dhrubabasu Jun 12, 2023
6c8381e
nit
dhrubabasu Jun 12, 2023
5b8f55d
nit
dhrubabasu Jun 12, 2023
399dcdf
nit
dhrubabasu Jun 12, 2023
a825a8b
nit
dhrubabasu Jun 12, 2023
11497ad
nits
dhrubabasu Jun 12, 2023
50c3320
Merge branch 'dev' into testing-snow
Jun 13, 2023
e120b39
moar Empty
dhrubabasu Jun 13, 2023
e286b32
Merge branch 'dev' into testing-snow
dhrubabasu Jun 14, 2023
b4458eb
Merge branch 'dev' into testing-snow
dhrubabasu Jun 15, 2023
14034f3
pr review
dhrubabasu Jun 15, 2023
46cd63d
Merge branch 'dev' into testing-snow
StephenButtolph Jun 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scripts/lint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,16 @@ function test_require_error_is_no_funcs_as_params {
}

function test_require_equal_zero {
if grep -R -o -P 'require\.Equal\((t, )?(u?int\d+\(0\)|0)' .; then
# check if the first arg, other than t, is 0
if grep -R -o -P 'require\.Equal\((t, )?(u?int\d*\(0\)|0)' .; then
echo ""
echo "Use require.Zero instead of require.Equal when testing for 0."
echo ""
return 1
fi

if grep -R -zo -P 'require\.Equal\(.+?, (u?int\d+\(0\)|0)\)\n' .; then
# check if the last arg is 0
if grep -R -zo -P 'require\.Equal\(.+?, (u?int\d*\(0\)|0)\)\n' .; then
echo ""
echo "Use require.Zero instead of require.Equal when testing for 0."
echo ""
Expand All @@ -74,7 +76,7 @@ function test_require_equal_zero {
}

function test_require_len_zero {
if grep -R -o -P 'require\.Len\((t, )?.+?, 0(,|\))' .; then
if grep -R -o -P 'require\.Len\((t, )?.+, 0(,|\))' .; then
echo ""
echo "Use require.Empty instead of require.Len when testing for 0 length."
echo ""
Expand Down