Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use require.IsType for type assertions in tests #1458

Merged
merged 20 commits into from
May 3, 2023
Merged

use require.IsType for type assertions in tests #1458

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
33e3860
use `require.IsType` for type assertions in tests
dhrubabasu May 3, 2023
c08221b
wip
dhrubabasu May 3, 2023
069c1db
reduce diff
dhrubabasu May 3, 2023
6df6804
reduce diff
dhrubabasu May 3, 2023
e741070
reduce diff
dhrubabasu May 3, 2023
07ef044
reduce diff
dhrubabasu May 3, 2023
bf13df0
reduce diff
dhrubabasu May 3, 2023
ee23c0d
reduce diff
dhrubabasu May 3, 2023
69404db
reduce diff
dhrubabasu May 3, 2023
f917051
reduce diff
dhrubabasu May 3, 2023
f4efe91
reduce diff
dhrubabasu May 3, 2023
ecbafa5
reduce diff
dhrubabasu May 3, 2023
977255a
reduce diff
dhrubabasu May 3, 2023
dbe1993
import nits
dhrubabasu May 3, 2023
e79f9f2
reduce diff
dhrubabasu May 3, 2023
88f9e00
reduce diff
dhrubabasu May 3, 2023
9f7f1d8
reduce diff
dhrubabasu May 3, 2023
b414e98
oops
dhrubabasu May 3, 2023
dbf3ad8
merged
StephenButtolph May 3, 2023
7f30459
Merge branch 'dev' into require-is-type
StephenButtolph May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merged
  • Loading branch information
@StephenButtolph
StephenButtolph committed May 3, 2023
commit dbf3ad8370ff894890e0f2605b9914699e25e196
8 changes: 4 additions & 4 deletions network/throttling/inbound_resource_throttler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ func TestNewSystemThrottler(t *testing.T) {
require.NoError(err)
require.IsType(&systemThrottler{}, throttlerIntf)
throttler := throttlerIntf.(*systemThrottler)
require.EqualValues(clock, config.Clock)
require.EqualValues(time.Second, config.MaxRecheckDelay)
require.EqualValues(cpuTracker, throttler.tracker)
require.EqualValues(targeter, throttler.targeter)
require.Equal(clock, config.Clock)
require.Equal(time.Second, config.MaxRecheckDelay)
require.Equal(cpuTracker, throttler.tracker)
require.Equal(targeter, throttler.targeter)
}

func TestSystemThrottler(t *testing.T) {
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.