-
Notifications
You must be signed in to change notification settings - Fork 741
Update BLS signature ordering to avoid public key compression #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Results for Before:
After:
|
aaronbuchwald
approved these changes
Apr 25, 2023
abi87
approved these changes
Apr 26, 2023
dhrubabasu
approved these changes
Apr 26, 2023
joshua-kim
added a commit
to joshua-kim/avalanchego
that referenced
this pull request
Apr 27, 2023
commit b11e9bb Author: Stephen Buttolph <stephen@avalabs.org> Date: Wed Apr 26 14:30:28 2023 -0400 Update BLS signature ordering to avoid public key compression (ava-labs#1416) commit e44ef23 Author: Stephen Buttolph <stephen@avalabs.org> Date: Wed Apr 26 11:57:39 2023 -0400 Honor AllowPrivateIPs config (ava-labs#1422) commit 6fb00b9 Author: Stephen Buttolph <stephen@avalabs.org> Date: Wed Apr 26 11:56:46 2023 -0400 Simplify IP status calculation (ava-labs#1421)
joshua-kim
pushed a commit
to joshua-kim/avalanchego
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Public key compression should be avoided in any code hot-paths.
How this works
Uses the uncompressed format rather than the compressed format.
How this was tested
CI