Remove avalanche bootstrapping -> avalanche consensus transition #1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
changed the title
StephenButtolph
added
consensus
…into linearize-on-start
StephenButtolph
commented
Apr 25, 2023
StephenButtolph
removed
the
DO NOT MERGE
gyuho
reviewed
Apr 25, 2023
|
|
||
| // If the subnet hasn't finished bootstrapping, this chain should remain | ||
| // syncing. | ||
| if !b.Config.BootstrapTracker.IsBootstrapped() { |
There was a problem hiding this comment.
Nope! This is handled in snowman bootstrapping now.
danlaine
approved these changes
Apr 25, 2023
StephenButtolph
commented
Apr 25, 2023
danlaine
approved these changes
Apr 25, 2023
gyuho
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Now that Cortina has been activated, Avalanche bootstrapping should always result in accepting the stop vertex. This means that that Avalanche engine is completely inaccessible.
How this works
How this was tested
CI + manually.