-
Notifications
You must be signed in to change notification settings - Fork 741
Add benchmark for gRPC GetValidatorSet #1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
darioush
reviewed
Apr 11, 2023
darioush
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
StephenButtolph
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
It is important to understand the cost of requesting a large validator set over gRPC. Even though the call is local there is a cost for round trip serialization. The server + wire cost for serving 2000 records is only about 1.6ms. The rest of the time is spent converting bytes to BLS keys (cgo) client side.
ref
avalanchego/snow/validators/gvalidators/validator_state_client.go
Line 75 in 7d73b59
profiles
benchvset.cpu
benchvset.mem
How this works
Uses golang native benchmark tooling
How this was tested
manual