-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pchain validators repackaging #1284
Merged
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
795a10a
repack pchain validators
abi87 629ffd8
nit
abi87 61fd676
Merge branch 'dev' into pchain_proposers_repack
StephenButtolph e725784
nits
abi87 0c8bc40
nits
abi87 7bd3093
Merge branch 'dev' into pchain_proposers_repack
abi87 d91c656
Merge branch 'dev' into pchain_proposers_repack
abi87 97bafa4
minor renaming
abi87 d9b9452
clock cleanup
abi87 2248f3c
Merge branch 'dev' into pchain_proposers_repack
abi87 bea7c15
Merge branch 'dev' into pchain_proposers_repack
abi87 816dd86
Merge branch 'dev' into pchain_proposers_repack
abi87 da0d822
Merge branch 'dev' into pchain_proposers_repack
abi87 18e9bb8
Merge branch 'dev' into pchain_proposers_repack
abi87 9a978cc
Merge branch 'dev' into pchain_proposers_repack
abi87 db2e956
Merge branch 'dev' into pchain_proposers_repack
abi87 bcbe002
Merge branch 'dev' into pchain_proposers_repack
abi87 d53f5e9
Merge branch 'dev' into pchain_proposers_repack
abi87 fa3ee2b
Merge branch 'dev' into pchain_proposers_repack
abi87 4f24a50
Merge branch 'dev' into pchain_proposers_repack
abi87 ee25500
nits
abi87 42b1dd5
cleanup
abi87 a736dfc
fixed cleanup
abi87 40e6092
Merge branch 'dev' into pchain_proposers_repack
abi87 cb1eafb
nits
abi87 1e3d889
Merge branch 'dev' into pchain_proposers_repack
abi87 c2ccff7
Merge branch 'dev' into pchain_proposers_repack
abi87 4855ec9
Merge branch 'dev' into pchain_proposers_repack
abi87 330e83a
fix merge
StephenButtolph 79262a5
nit rename
StephenButtolph d55469b
nit rename
StephenButtolph cfbd56f
remove duplicate comments
StephenButtolph dcc6aa7
minimize interface size
StephenButtolph bb3be27
license
StephenButtolph 12590b2
Merge branch 'dev' into pchain_proposers_repack
StephenButtolph File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
nits
- Loading branch information
commit cb1eafbcedd8b0ff8473a92e90d3978e495c1bd1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need this interface, we can have an interface with only Track that is implemented by the same struct.
We could also rename Track to OnAccept and name the interface AcceptedBlockTracker or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Track sucks and we should find a better name. OnAccept is a reasonble suggestion and I have implemented it.
On the other hand, I don't really like the idea of reducing Manager interface to
AcceptedBlockTracker
.This manager is a pretty big class doing a bunch of not-so-related things, which are together only because there are listed under the same
validators.State
. It seems to me thatAcceptedBlockTracker
goes in the direction of slicing off one of this things which may be the right thing to do here. Only if we go there, we should probably first slicevalidators.State
and then extract the OnAccept interface.