Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flags usage with pflags #1270

Merged
merged 8 commits into from
Mar 31, 2023
Merged

Replace flags usage with pflags #1270

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
75e2e56
use pflag instead of flag
Mar 24, 2023
0156743
fix(?) test
Mar 24, 2023
35fbb96
remove empty file
Mar 24, 2023
300db84
Merge branch 'dev' into pflags
Mar 29, 2023
b79e964
cleanp test
Mar 29, 2023
e7e7343
add comment on deprecatedKeys
Mar 30, 2023
e1500f4
Merge remote-tracking branch 'upstream/dev' into pflags
Mar 30, 2023
b38facb
Merge branch 'dev' into pflags
StephenButtolph Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(?) test
  • Loading branch information
Dan Laine committed Mar 24, 2023
commit 0156743c5a01c3d7827bf16b80a80bd4efeb3d92
3 changes: 3 additions & 0 deletions config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"path/filepath"
"testing"

"github.com/spf13/pflag"
"github.com/spf13/viper"

"github.com/stretchr/testify/require"
Expand Down Expand Up @@ -603,6 +604,8 @@ func setupFile(t *testing.T, path string, fileName string, value string) {
func setupViperFlags() *viper.Viper {
v := viper.New()
fs := BuildFlagSet()
pflag.CommandLine = pflag.NewFlagSet(os.Args[0], pflag.PanicOnError) // flags are now reset
pflag.Parse()
if err := v.BindPFlags(fs); err != nil {
log.Fatal(err)
}
Expand Down