Added a new flow allowing to delegate to many nodes in a row #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat/ledger erc20
Update addERC20 modal styling
Refactor tokenlist code Add Token List button to portfolio
Remove unnecessary closeModal calls fix method typo
ERC20 Support
Phase 2 Prod Release
Switch divRound with just div for calculating EVM nAVAX balance
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2. - [Release notes](https://github.com/npm/ssri/releases) - [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md) - [Commits](npm/ssri@v6.0.1...v6.0.2) Signed-off-by: dependabot[bot] <support@github.com>
Switch back to signing hash for staking txs
…/ssri-6.0.2 Bump ssri from 6.0.1 to 6.0.2
Fix network Id bug where mainnet is not recognized
Fix number parsin on network forms
Feat/rewards
…Init network using that.
Feat/header credentials
Update master
|
Feedback as requested on Discord. WRT the PR itself, two bikesheds
I can't comment much on the code. It's looks well laid out, and generally plausible, but my JavaScript knowledge is still jQuery circa 2010. |
|
I'll reopen the MR elsewhere, looks like I can't put the MR back to master |
|
MR re-opened here: #115 |
moreati
pushed a commit
to moreati/wallet-site
that referenced
this pull request
Feb 24, 2022
…dger-parsing Fix/as 318 implement ledger parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to delegate to many nodes in one flow:
The purpose of the PR is to make it easier for people to like to diversify the delegate nodes to diminish the risk of nodes being taken down, especially in times of instability like these days.
Aside from this change, I also fixed the same P-CHAIN address being used over and over again when delegating during the same session, this fix is to enforce BIP-32 thus, increasing security and privacy, as no node will be able to tell how much balance you carry easily.
Added a new localization key:
I'm not sure what's the process to add the translation for this key, if anyone could point me to it, I'll gladly add the locas there, the meant loca for english is just "Finish"