Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes clippy warnings which were most easily able to be fixed.
The primary chunk of warnings were due to a associated function
Self::default()
existing but also implementingDefault
. There should (hopefully) be no breaking changes from removing the associated function as user's code will fall back toDefault::default
.Another clippy warning fix that is a potential breaking change is implementing Default on
Transaction
andTx
, though this is only a issue in contrived scenarios and the crate is still in 0.x.A weird edge case was when encountering
Config::default_main()
, I decided to keep the associated function for stability reasons and I just madeDefault::default()
call it.As for the remaining clippy warnings, only 3 remain:
new
doesn't returnSelf
for many typesCommonVm::initialize
proto/pb/message.rs