Remove Jsonrpc #88
Merged
Remove Jsonrpc #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angel-Petrov
requested review from
gyuho,
hexfusion and
richardpringle
as code owners
richardpringle
requested changes
Nov 9, 2023
There was a problem hiding this comment.
Haha 😅 so this was a fun exercise...
Turns out we don't need to migrate to jsonrpsee, but remove the dependency entirely. We had a single test, testing code that was written inside the integration tests directory... so silly.
Anyway, I think my change requests are pretty clear. Let me know if you have any questions and thank you for the contribution!
richardpringle
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
This replaces bothjsonrpc-coreandjsonrpc-http-serverwith the newerjsonrpsee-coreandjsonrpsee-typescrates. The new jsonrpsee crates have been moved intodev-dependenciesas jsonrpc was only used for its re-exportedfuturesmodule in theavalanche-typeslibrary (which was able to be replaced).The majority of this PR has been modifying tests in
crates/avalanche-types/tests/rpc/as that was the primary use of jsonrpc. With some uses of the re-exportedfuturescrate being replaced as well.This also removes additional tests which are no longer necessary but required the crate.