Networking & Other Refactoring

[dimitrovmaksim]

What this PR does:

• Replacing manually parsing localhost ip with LOCALHOST constant
• array::from_fn to avoid duplication when generating random IDs
• Make functions which have paramaters for ip: IpAddr, port: u16 instead have SocketAddr
• Having Message::tracked_subnets accept any slice instead of just Vecs (overly strict type for what is needed)
• Change TLS server/client config error to be consistently io::error::ErrorKind::Other

[richardpringle]

This is a lot nicer! Only two of my comments are actual change requests. Feel free to resolve the others.

[richardpringle]

👍

[richardpringle]

We don't use other_certificates. It would probably be better to do the following:

        let (peer_certificate, total_certificates) = conn
            .peer_certificates()
            .and_then(|certs| {
                let total_certs = certs.len();
                certs.split_first().map(|(first, _)| (first, total_certs))
            })
            .ok_or(Error::new(
                ErrorKind::NotConnected,
                "no peer certificate found",
            ))?;

        let peer_node_id = node::Id::from_cert_der_bytes(&peer_certificate.0)?;
        info!(
            "successfully connected to {} (total {} certificates, first cert {}-byte)",
            peer_node_id,
            total_certificates,
            peer_certificate.0.len(),
        );

[richardpringle]

👍

[richardpringle]

Much nicer, 🥇

[richardpringle]

@dimitrovmaksim, @Angel-Petrov has an unsigned commit on this branch. If one of you can sign that commit, we can merge.

[dimitrovmaksim]

@dimitrovmaksim, @Angel-Petrov has an unsigned commit on this branch. If one of you can sign that commit, we can merge.

I signed it, hopefully I did not break something else 😅