Added Hardhat quickstart, reworked smart contracts section #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
reviewed
Feb 2, 2021
| "compile": "npx hardhat compile", | ||
| ``` | ||
|
|
||
| Run `yarn compile` to make sure your project compiles. |
There was a problem hiding this comment.
When I do this I get:
dan@compy:~/Desktop/smart-contract-quickstart$ yarn compile
yarn run v1.22.10
$ rimraf ./build/
$ npx hardhat compile
✔ Help us improve Hardhat with anonymous crash reports & basic usage data? (Y/n) · true
Downloading compiler 0.6.4
Compiling 1 file with 0.6.4
contracts/MockContract.sol:84:1: Warning: This contract has a payable fallback function, but no receive ether function. Consider adding a receive ether function.
contract MockContract is MockInterface {
^ (Relevant source part starts here and spans across multiple lines).
contracts/MockContract.sol:334:2: The payable fallback function is defined here.
fallback () payable external {
^ (Relevant source part starts here and spans across multiple lines).
Downloading compiler 0.7.0
Compiling 5 files with 0.7.0
@openzeppelin/contracts/token/ERC20/ERC20.sol:55:5: Warning: Visibility for constructor is ignored. If you want the contract to be non-deployable, making it "abstract" is sufficient.
constructor (string memory name_, string memory symbol_) public {
^ (Relevant source part starts here and spans across multiple lines).
Compilation finished successfully
Done in 7.01s.
danlaine
reviewed
Feb 2, 2021
|
|
||
| ## Prepare to Deploy | ||
|
|
||
| Edit the deployment script in `scripts/deploy.js`. You can add other contract deployments there. |
There was a problem hiding this comment.
How does one add a contract deployment?
danlaine
reviewed
Feb 2, 2021
build/tutorials/smart-contracts/smart-contracts-using-hardhat.md
Outdated
Show resolved
Hide resolved
danlaine
reviewed
Feb 2, 2021
| "deploy-fuji": "npx hardhat run scripts/deploy.js --network fuji", | ||
| ``` | ||
|
|
||
| Deploy your contract to the Hardhat network with `yarn test-deploy`. |
There was a problem hiding this comment.
Can you explain what it means to deploy something to the Hardhat network?
People will get confused about what the "Hardhat" network (as opposed to Avalanche) is
danlaine
reviewed
Feb 2, 2021
|
|
||
| ## Deploy to Fuji or Mainnet | ||
|
|
||
| You need to add your private key to the accounts field in [hardhat.config.js]. |
There was a problem hiding this comment.
Can you please provide more details here? Perhaps an example?
People will ask, "what private key? How should this file look when I've done it right?"
danlaine
reviewed
Feb 2, 2021
|
|
||
| You need to add your private key to the accounts field in [hardhat.config.js]. | ||
|
|
||
| Then run `yarn deploy` for mainnet or `yarn deploy-fuji` for fuji. |
There was a problem hiding this comment.
Can you explain what this will do, exactly?
danlaine
reviewed
Feb 2, 2021
|
|
||
| ## Hardhat Tasks | ||
|
|
||
| You can define custom Hardhat tasks in [hardhat.config.js]. There are two tasks included as examples—`accounts` and `balances` both of which have scripts in [package.json](https://github.com/ava-labs/avalanche-smart-contract-quickstart/blob/master/package.json). |
There was a problem hiding this comment.
Can you explain what a Hardhat task is?
danlaine
reviewed
Feb 2, 2021
| "balances": "npx hardhat balances" | ||
| ``` | ||
|
|
||
| `yarn accounts` will print the list of accounts. `yarn balances` prints the list of AVAX account balances. |
There was a problem hiding this comment.
Adressed with an example
danlaine
reviewed
Feb 2, 2021
|
|
||
| ## Sending AVAX | ||
|
|
||
| [package.json](https://github.com/ava-labs/avalanche-smart-contract-quickstart/blob/master/package.json) has a `send-avax` script which is found in [scripts/sendAvax.js](https://github.com/ava-labs/avalanche-smart-contract-quickstart/blob/master/scripts/sendAvax.js). |
There was a problem hiding this comment.
I find it useful to quickly jump into the script to check it out. but could be removed.
danlaine
reviewed
Feb 2, 2021
| "send-avax": "npx hardhat run scripts/sendAvax.js", | ||
| ``` | ||
|
|
||
| Run it with `yarn send-avax`. |
Apparently, some Ubuntu installations don't come with 'curl' preinstalled, added check and install if missing.
- added to stop the script on errors - modified tutorial so fetch command updates the script if it's run again
* Fix `us` -> `is` typo * Remove ERC20 steps
We want to discourage RasPi-s going forward, they are becoming underpowered for the C-chain activity
It was moved in this PR: OpenZeppelin/openzeppelin-contracts#2503
|
Integrated from another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.