-
Notifications
You must be signed in to change notification settings - Fork 97
Remove unused commands #2774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove unused commands #2774
Conversation
) | ||
|
||
// avalanche blockchain validators | ||
func newValidatorsCmd() *cobra.Command { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have avalanche validators list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to integrate this into validators list, then remove. this is for another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also we need to mark for deprecation notice at least one release
Do we collect user metrics, like which cmd user used, and errors occurred etc.? if so that metrics data will be useful for us to make decisions like this. btw there may be privacy considerations if we want to do this. |
https://us.posthog.com/project/23813
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe we remove all the commands. Publish for sure. But no validators and stats. Those should be integrated somewhere else.
Most probably we want to merge that code into validator command group, but not fully remove it |
Reduce the amount of code we need to support E2E.
Deleted these less used commands, pls correct me if these commands are important.