Skip to content

Remove unused commands #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove unused commands #2774

wants to merge 2 commits into from

Conversation

sukantoraymond
Copy link
Collaborator

@sukantoraymond sukantoraymond commented Apr 29, 2025

Reduce the amount of code we need to support E2E.

Deleted these less used commands, pls correct me if these commands are important.

)

// avalanche blockchain validators
func newValidatorsCmd() *cobra.Command {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have avalanche validators list

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to integrate this into validators list, then remove. this is for another PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also we need to mark for deprecation notice at least one release

@Tonix517
Copy link
Collaborator

Do we collect user metrics, like which cmd user used, and errors occurred etc.? if so that metrics data will be useful for us to make decisions like this.

btw there may be privacy considerations if we want to do this.

@Tonix517
Copy link
Collaborator

https://us.posthog.com/project/23813

Do we collect user metrics, like which cmd user used, and errors occurred etc.? if so that metrics data will be useful for us to make decisions like this.

btw there may be privacy considerations if we want to do this.

@github-project-automation github-project-automation bot moved this from Backlog 🗄️ to In Review 👀 in avalanchego Apr 29, 2025
Copy link
Collaborator

@felipemadero felipemadero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we remove all the commands. Publish for sure. But no validators and stats. Those should be integrated somewhere else.

@github-project-automation github-project-automation bot moved this from In Review 👀 to In Progress 🏗 in avalanchego Apr 30, 2025
@felipemadero
Copy link
Collaborator

I don't believe we remove all the commands. Publish for sure. But no validators and stats. Those should be integrated somewhere else.

Most probably we want to merge that code into validator command group, but not fully remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress 🏗️
Development

Successfully merging this pull request may close these issues.

3 participants