Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sdk test to example #2211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename sdk test to example #2211

wants to merge 1 commit into from

Conversation

sukantoraymond
Copy link
Collaborator

@sukantoraymond sukantoraymond commented Oct 2, 2024

Why this should be merged

To pass CI without /sdk/ filter

How this was tested

CI should be green without /sdk/ filter in go test

How is this documented

no documentation neccessary

@sukantoraymond sukantoraymond requested a review from a team as a code owner October 2, 2024 22:17
@michaelkaplan13
Copy link
Collaborator

Could we rename the functions in the file something other than TestXXX(), and add some comments about what the examples show/how to run them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog 🗄️
Development

Successfully merging this pull request may close these issues.

2 participants