Skip to content

Commit

Permalink
style(dashboard): minor improvements to chart context menu (apache#11170
Browse files Browse the repository at this point in the history
)

Bumping "Explore/edit chart" as the first option. Getting rid of the
old "edit chart properties" deprecated CRUD link
  • Loading branch information
mistercrunch authored and auxten committed Nov 20, 2020
1 parent bf5ae4f commit e94f1b0
Showing 1 changed file with 3 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -158,22 +158,16 @@ class SliceHeaderControls extends React.PureComponent {
</MenuItem>
)}

{this.props.sliceCanEdit && (
<MenuItem href={slice.edit_url} target="_blank">
{t('Edit chart metadata')}
{this.props.supersetCanExplore && (
<MenuItem onClick={this.exploreChart}>
{t('Explore chart')}
</MenuItem>
)}

{this.props.supersetCanCSV && (
<MenuItem onClick={this.exportCSV}>{t('Export CSV')}</MenuItem>
)}

{this.props.supersetCanExplore && (
<MenuItem onClick={this.exploreChart}>
{t('Explore chart')}
</MenuItem>
)}

<MenuItem onClick={this.handleToggleFullSize}>{resizeLabel}</MenuItem>

<URLShortLinkModal
Expand Down

0 comments on commit e94f1b0

Please sign in to comment.