Skip to content

More appropriate return code for sendMessage method #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2020
Merged

More appropriate return code for sendMessage method #34

merged 2 commits into from
Mar 24, 2020

Conversation

jxltom
Copy link
Collaborator

@jxltom jxltom commented Mar 18, 2020 •
edited
Loading

  1. When all three tx buffer are buzy, it is more appropriate to return ERROR_ALLTXBUSY in sendMessage(const struct can_frame *frame)

  2. If TXBnCTRL indicates message is lost or lost arbitration or bus error, it is more appropriate to consider it as ERROR_FAILTX in MCP2515::sendMessage(const TXBn txbn, const struct can_frame *frame)

@jxltom jxltom merged commit 2c3eb40 into autowp:master Mar 24, 2020
@jxltom jxltom deleted the jxltom-patch-1 branch March 24, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jxltom