Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data_collecting_tool): visualize collected acc and vel grid #83

Merged
merged 7 commits into from
Jul 26, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jul 23, 2024

Description

visualize collected acc and vel grid

data_collection_tools-2024-07-24_00.47.03.mp4

Related links

Tests performed

psim

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
self.collected_data_counts = np.zeros((self.num_bins, self.num_bins))
self.v_bins = np.linspace(self.v_min, self.v_max, self.num_bins + 1)
self.a_bins = np.linspace(self.a_min, self.a_max, self.num_bins + 1)
self.fig, self.axs = plt.subplots(2, 1, figsize=(10, 12))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kosuke55

Here, plt is being used, but whether matplotlib is imported is managed by a flag as shown below.

Therefore, it seems that an error occurs when this flag is set to False.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, thanks, make it always import in
0938137

kosuke55 added 2 commits July 25, 2024 19:41
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55
Copy link
Contributor Author

update division

image

kosuke55 added 3 commits July 26, 2024 16:40
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 merged commit a1aba06 into main Jul 26, 2024
17 checks passed
@kosuke55 kosuke55 deleted the feat/visualize_collected_data branch July 26, 2024 10:07
@kosuke55
Copy link
Contributor Author

@YoshihiroKogure
thanks for the support 2401e59
this fix blinking of grid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants