Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_debug_tools): add processing time visualizer #75

Merged

Conversation

yhisaki
Copy link
Contributor

@yhisaki yhisaki commented Jul 11, 2024

Description

https://www.youtube.com/watch?v=TCyEaNf3nR4&ab_channel=YukinariHisaki

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki yhisaki requested a review from takayuki5168 July 11, 2024 06:52
<name>autoware_debug_tools</name>
<version>0.0.0</version>
<description>The autoware_debug_tools package</description>
<maintainer email="yhisaki31@gmail.com">hisaki</maintainer>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add me, Ota-kun and Takeuchi-kun.

@@ -0,0 +1,82 @@
import curses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add README about what is the purpose of this script and how to use it.
You can refer to README of planning_debug_tools in autoware_tools.

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yhisaki yhisaki merged commit 031ec63 into autowarefoundation:main Jul 12, 2024
16 checks passed
@yhisaki yhisaki deleted the add-processing_time_visualizer branch July 12, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants