feat(lanelet2_map_validator): add test codes for existing validators #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaikiYamada4
requested review from
anhnv3991,
soblin,
Motsu-san,
SakodaShintaro and
YamatoAndo
as code owners
7 tasks
Added test codes using these maps. Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Added regulatory_elements_details_for_crosswalks test Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
…fers) to look into the loading errors Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
TaikiYamada4
force-pushed
the
feat/lanelet2_map_validator/add_test_environment
branch
from
d9c96c1 to
6534914
Compare
YamatoAndo
reviewed
Nov 18, 2024
map/autoware_lanelet2_map_validator/test/src/map_validation_tester.hpp
Outdated
Show resolved
Hide resolved
YamatoAndo
reviewed
Nov 18, 2024
...ware_lanelet2_map_validator/test/src/test_regulatory_elements_details_for_traffic_lights.cpp
Outdated
Show resolved
Hide resolved
YamatoAndo
reviewed
Nov 18, 2024
...autoware_lanelet2_map_validator/test/src/test_regulatory_elements_details_for_crosswalks.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
|
@YamatoAndo |
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
|
@YamatoAndo I've fixed the sample_map.osm |
…idator/add_test_environment Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
soblin
reviewed
Nov 22, 2024
|
|
||
| class MapValidationTester : public ::testing::Test | ||
| { | ||
| protected: |
There was a problem hiding this comment.
Suggested change
| protected: | |
| protected: | |
| virtual void SetUp() { | |
| map_ = lanelet::load(package_share_directory + "/data/map/" + file_name, *projector, &loading_errors_); |
and delete load_target_map function if possible
There was a problem hiding this comment.
Isn't this difficult to pass the target map file to validate?
One test code will try to validate various maps.
There was a problem hiding this comment.
Please forget my comment. Possibly we can use TestWithParam in the future when the number of test suites grow.
https://github.com/google/googletest/blob/main/docs/advanced.md#how-to-write-value-parameterized-tests
soblin
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR revises the test system in lanelet2_map_validator such like
I made the medium size map (sample_map.osm) by modifying lanelet2_map.osm from
autoware_test_utils.I modified that map so that the current requirements in the
autoware_requirement_set.jsonwill pass.Related links
None
Tests performed
1. Test codes
I tested the test codes through
2. Test sample_map.osm
I tested that sample_map.osm passes
vm-02-02,vm-04-01andvm-05-01through the following command.The figure below is the console output I got.
Notes for reviewers
None
Interface changes
None
Effects on system behavior
Test algorithm changed.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.