Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): fix isStopped judgement #9585

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Dec 6, 2024

Description

in #9522, time duration threshould is used for velocity check mistakenly.

image

Related links

Parent Issue:

  • Link

How was this PR tested?

psim with scenario

image

2024/12/06 https://evaluation.tier4.jp/evaluation/reports/ede3fa66-17c1-590b-999d-3f21a2284947/?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@kosuke55 kosuke55 marked this pull request as ready for review December 6, 2024 07:47
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 6, 2024
@kosuke55 kosuke55 requested a review from soblin December 6, 2024 07:47
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 29.58%. Comparing base (ede3f23) to head (a8394f5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #9585    +/-   ##
========================================
  Coverage   29.57%   29.58%            
========================================
  Files        1442     1447     +5     
  Lines      108520   108585    +65     
  Branches    41394    41413    +19     
========================================
+ Hits        32096    32122    +26     
- Misses      73060    73337   +277     
+ Partials     3364     3126   -238     
Flag Coverage Δ *Carryforward flag
differential 0.52% <0.00%> (?)
total 29.60% <ø> (+0.02%) ⬆️ Carriedforward from ede3f23

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 90bf2d0 into autowarefoundation:main Dec 7, 2024
35 checks passed
@kosuke55 kosuke55 deleted the fix/is_stopped branch December 7, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants