Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_mpc_lateral_controller): fix variableScope #9390

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Nov 19, 2024

Description

Fixed the following cppcheck variableScope warning

control/autoware_mpc_lateral_controller/src/mpc.cpp:514:9: style: The scope of the variable 'idx_x_i_prev' can be reduced. [variableScope]
    int idx_x_i_prev = (i - 1) * DIM_X;
        ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@veqcc veqcc self-assigned this Nov 19, 2024
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Nov 19, 2024
@veqcc veqcc added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 19, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc enabled auto-merge (squash) November 19, 2024 13:06
@veqcc veqcc merged commit de9d9cb into autowarefoundation:main Nov 19, 2024
35 of 36 checks passed
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.76%. Comparing base (5778e01) to head (9396b37).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9390      +/-   ##
==========================================
- Coverage   29.77%   29.76%   -0.01%     
==========================================
  Files        1338     1338              
  Lines      103364   103381      +17     
  Branches    40234    40237       +3     
==========================================
+ Hits        30773    30774       +1     
- Misses      69606    69621      +15     
- Partials     2985     2986       +1     
Flag Coverage Δ *Carryforward flag
differential 34.34% <100.00%> (?)
total 29.77% <ø> (-0.01%) ⬇️ Carriedforward from 5778e01

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@veqcc veqcc deleted the fix/variableScope branch November 19, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants