Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_vehicle_cmd_gate): remove unused variable #9377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Nov 19, 2024

Description

Removed unused is_filtered_marker_published_ variable.

This solves the following clang-tidy error

clang-tidy-14 --use-color -p=build/ /home/veqcc/work/autoware/src/universe/autoware.universe/control/autoware_vehicle_cmd_gate/src/vehicle_cmd_gate.cpp
/home/veqcc/work/autoware/src/universe/autoware.universe/control/autoware_vehicle_cmd_gate/src/vehicle_cmd_gate.hpp:140:8: error: private field 'is_filtered_marker_published_' is not used [clang-diagnostic-unused-private-field]
  bool is_filtered_marker_published_ = false;
       ^
1 error generated.
Error while processing /home/veqcc/work/autoware/src/universe/autoware.universe/control/autoware_vehicle_cmd_gate/src/vehicle_cmd_gate.cpp.
Found compiler error(s).

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
@veqcc veqcc self-assigned this Nov 19, 2024
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Nov 19, 2024
Copy link

github-actions bot commented Nov 19, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.78%. Comparing base (a7cc44d) to head (b3994d1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9377      +/-   ##
==========================================
- Coverage   29.94%   29.78%   -0.17%     
==========================================
  Files        1338     1341       +3     
  Lines      103365   103173     -192     
  Branches    40236    40159      -77     
==========================================
- Hits        30957    30732     -225     
- Misses      69407    69466      +59     
+ Partials     3001     2975      -26     
Flag Coverage Δ *Carryforward flag
differential 11.66% <ø> (?)
total 29.78% <ø> (-0.17%) ⬇️ Carriedforward from 8376a69

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant