Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner_common): fix findOffsetSegment #9130

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 21, 2024

Description

fix findOffsetSegment remain length calculation

before

findForwardOffsetSegment

    /**
     *   (base_idx) --- offset_length --------->
     *              --------- (i) <-------------<-- remain --> (i+1)
     */

after

findForwardOffsetSegment

    /**
     *   (base_idx) --- offset_length --------->
     *              --------- (i) <-- remain -->-----------> (i+1)
     */

findBackwardOffsetSegment

    /**
     *                         <-------- offset_length --- (base_idx)
     *  ----- (i) <-- remain -->-------> (i+1)
     */

calcTargetPose

  /**
   * (front) <-- remain_length --> (interp) <----> (back)
   */

Related links

move from #9105

Parent Issue:

  • Link

How was this PR tested?

tested in later PR unit test ( #9107)

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 21, 2024
Copy link

github-actions bot commented Oct 21, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 21, 2024
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the fix/behavior_velocity_common_functions branch from 33ddf1d to e9a3eb2 Compare October 21, 2024 12:18
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.54%. Comparing base (6ff2121) to head (e9a3eb2).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9130      +/-   ##
==========================================
- Coverage   27.55%   27.54%   -0.02%     
==========================================
  Files        1304     1308       +4     
  Lines      101047   101093      +46     
  Branches    39236    39238       +2     
==========================================
- Hits        27843    27842       -1     
- Misses      70580    70627      +47     
  Partials     2624     2624              
Flag Coverage Δ *Carryforward flag
differential 21.53% <100.00%> (?)
total 27.55% <ø> (-0.01%) ⬇️ Carriedforward from 6ff2121

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit e5ad593 into autowarefoundation:main Oct 22, 2024
30 of 32 checks passed
@kosuke55 kosuke55 deleted the fix/behavior_velocity_common_functions branch October 22, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants