Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_map_based_prediction): adjust lateral duration when object is behind reference path #8973

Merged

Conversation

technolojin
Copy link
Contributor

Description

The previous update of the map_based_prediction had multiple function changes of path generation algorithms.
One of them was searchProperStartingRefPathIndex, which finds a proper reference path position to generate natural path.

In case of the lateral_duration was too short to reach the reference path point, the path tend to be generated unnaturally.

Planning simulator (PSIM)
condition: simulated car with speed of 1.5 m/s. (which makes the fixed lateral_duration short to reach the reference path point.

Before

Screenshot from 2024-09-27 12-44-17

After

Screenshot from 2024-09-27 12-50-20

Related links

#8602
#8811

How was this PR tested?

Tested in PSIM

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin self-assigned this Sep 27, 2024
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Sep 27, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin changed the title fix: adjust lateral duration when object is behind reference path fix(autoware_map_based_prediction): adjust lateral duration when object is behind reference path Sep 27, 2024
@technolojin technolojin marked this pull request as ready for review September 27, 2024 07:49
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, LGTM

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 28.40%. Comparing base (9fd0dae) to head (f16a4e6).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...toware_map_based_prediction/src/path_generator.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8973      +/-   ##
==========================================
- Coverage   28.48%   28.40%   -0.09%     
==========================================
  Files        1314     1316       +2     
  Lines       98292    98338      +46     
  Branches    39995    39969      -26     
==========================================
- Hits        27999    27929      -70     
- Misses      70228    70344     +116     
  Partials       65       65              
Flag Coverage Δ *Carryforward flag
differential 1.82% <0.00%> (?)
total 28.44% <ø> (-0.04%) ⬇️ Carriedforward from 9fd0dae

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin merged commit 92bec0d into autowarefoundation:main Sep 30, 2024
42 of 44 checks passed
@technolojin technolojin deleted the fix/pred/curve-extrapolation branch September 30, 2024 00:35
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
…ct is behind reference path (autowarefoundation#8973)

fix: adjust lateral duration when object is behind reference path

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants