Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(simple_planning_simulator): remove unnecessary lines #8932

Conversation

Autumn60
Copy link
Contributor

Description

Remove unnecessary lines containing only semicolon.

double SimModelDelaySteerAccGeared::getWz()
{
return state_(IDX::VX) * std::tan(state_(IDX::STEER)) / wheelbase_;
;
}

double SimModelDelaySteerAccGearedWoFallGuard::getWz()
{
return state_(IDX::VX) * std::tan(state_(IDX::STEER)) / wheelbase_;
;
}

Related links

None.

How was this PR tested?

build succeeded.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Autumn60 <harada.akiro@gmail.com>
@Autumn60 Autumn60 changed the title chore(simple_planning_simulator): remove unnecessary semicolons chore(simple_planning_simulator): remove unnecessary lines Sep 20, 2024
@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Sep 20, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.99%. Comparing base (6465aaf) to head (6a0dd3f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8932      +/-   ##
==========================================
- Coverage   28.00%   27.99%   -0.01%     
==========================================
  Files        1317     1319       +2     
  Lines       98578    98583       +5     
  Branches    39770    39757      -13     
==========================================
- Hits        27604    27603       -1     
+ Misses      70902    70881      -21     
- Partials       72       99      +27     
Flag Coverage Δ *Carryforward flag
differential 25.07% <ø> (?)
total 27.99% <ø> (-0.01%) ⬇️ Carriedforward from fc283c5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Autumn60 Autumn60 merged commit d8dc258 into autowarefoundation:main Sep 20, 2024
44 checks passed
@Autumn60 Autumn60 deleted the chore/simple_planning_simulator/remove_unnecessary_line branch September 20, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants