Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_velocity_planner): disable randomly failing test #8923

Conversation

maxime-clem
Copy link
Contributor

Description

Disable a test in autoware_motion_velocity_planner_common that is randomly failing and can bother other PRs.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 19, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.98%. Comparing base (2a2d037) to head (012c9fa).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8923      +/-   ##
==========================================
- Coverage   27.99%   27.98%   -0.01%     
==========================================
  Files        1319     1323       +4     
  Lines       98744    98776      +32     
  Branches    39802    39802              
==========================================
+ Hits        27642    27646       +4     
- Misses      70948    70976      +28     
  Partials      154      154              
Flag Coverage Δ *Carryforward flag
differential 19.45% <ø> (?)
total 27.99% <ø> (ø) Carriedforward from 2a2d037

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit a98cfe8 into autowarefoundation:main Sep 20, 2024
42 checks passed
@maxime-clem maxime-clem deleted the fix/disable-random-failing-test branch September 20, 2024 06:48
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Sep 20, 2024
…foundation#8923)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants