Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ndt_scan_matcher)!: prefix package and namespace with autoware #8904

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Sep 18, 2024

Description

This PR will add an autoware_ prefix to ndt_scan_matcher package.

Related links

Changes in autoware-documentation: autowarefoundation/autoware-documentation#613

Parent Issue:

How was this PR tested?

Checked with running the autoware sample-map.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@SakodaShintaro SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 18, 2024
@SakodaShintaro
Copy link
Contributor

Sorry, I have merged the ekf PR.
Please resolve a conflict 🙏

@a-maumau
Copy link
Contributor Author

@SakodaShintaro I have resolved the conflict.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.15%. Comparing base (3b147dd) to head (5db2b05).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8904      +/-   ##
==========================================
+ Coverage   27.99%   28.15%   +0.16%     
==========================================
  Files        1319     1329      +10     
  Lines       98732    99578     +846     
  Branches    39798    40336     +538     
==========================================
+ Hits        27636    28040     +404     
- Misses      71020    71462     +442     
  Partials       76       76              
Flag Coverage Δ *Carryforward flag
differential 12.04% <ø> (?)
total 27.99% <ø> (ø) Carriedforward from 3b147dd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator, planning_simulator and e2e_simulator with AWSIM work well.

I checked

  • Directory Name

    • Add autoware_ as a prefix to the directory name.
  • packages.xml

    • Add autoware_ to the name element.
  • CMakeLists.txt

    • Change the project name to autoware_***.
    • Add autoware:: to PLUGIN.
  • Header Files (.hpp)

    • Add autoware:: to namespace.
    • Add autoware folder as necessary and update include statements accordingly.
  • Source Files (.cpp)

    • Add autoware:: inside RCLCPP_COMPONENTS_REGISTER_NODE.
  • Launch Files

    • Add autoware_ before find-pkg-share.
    • Change node pkg="<pkgname>" to autoware_<pkgname>.
  • Verification Points

    • Search find-pkg-share in autoware
    • Check README file (especially json schema)
    • Pay attention to complex cases like sensor_launch as seen in gnss_poser

@SakodaShintaro SakodaShintaro merged commit 313a383 into autowarefoundation:main Sep 19, 2024
31 of 32 checks passed
@a-maumau a-maumau deleted the mau/ref/localization/ndt_scan_matcher branch September 19, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants