Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_goal_planner_module): fix unusedFunction #8775

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck unusedFunction warnings.

planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/src/util.cpp:277:0: style: The function 'extractStaticObjectsInExpandedPullOverLanes' is never used. [unusedFunction]
PredictedObjects extractStaticObjectsInExpandedPullOverLanes(
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 requested a review from veqcc September 5, 2024 08:51
@kobayu858 kobayu858 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.99%. Comparing base (58c99fe) to head (df98fc0).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8775      +/-   ##
==========================================
- Coverage   25.01%   24.99%   -0.02%     
==========================================
  Files        1322     1326       +4     
  Lines       98044    98098      +54     
  Branches    37819    37821       +2     
==========================================
  Hits        24521    24521              
- Misses      70957    71011      +54     
  Partials     2566     2566              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 25.01% <ø> (+<0.01%) ⬆️ Carriedforward from 58c99fe

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858 kobayu858 merged commit abfa71e into autowarefoundation:main Sep 6, 2024
40 of 41 checks passed
emuemuJP pushed a commit to arayabrain/autoware.universe.origin that referenced this pull request Sep 10, 2024
…utowarefoundation#8775)

fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: emuemuJP <k.matsumoto.0807@gmail.com>
@kobayu858 kobayu858 deleted the fix/cppcheck_unusedFunction_pla-b2 branch October 1, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants