-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reaction_analyzer): fix include hierarchy of tf2_eigen #8663
fix(reaction_analyzer): fix include hierarchy of tf2_eigen #8663
Conversation
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8663 +/- ##
==========================================
- Coverage 24.17% 24.16% -0.01%
==========================================
Files 1399 1400 +1
Lines 102129 102160 +31
Branches 38778 38782 +4
==========================================
Hits 24686 24686
- Misses 74937 74968 +31
Partials 2506 2506
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Let me merge this PR right now without @brkay54 's review since the build of awf/autoware is failing. Thank you. |
…oundation#8663) Fixed include hierarchy of tf2_eigen Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
fix(reaction_analyzer): fix include hierarchy of tf2_eigen (autowarefoundation#8663)
…oundation#8663) Fixed include hierarchy of tf2_eigen Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
…oundation#8663) Fixed include hierarchy of tf2_eigen Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
…oundation#8663) Fixed include hierarchy of tf2_eigen Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
…oundation#8663) Fixed include hierarchy of tf2_eigen Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
…oundation#8663) Fixed include hierarchy of tf2_eigen Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
…oundation#8663) Fixed include hierarchy of tf2_eigen Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com>
…oundation#8663) Fixed include hierarchy of tf2_eigen Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Description
When I ran the following commands today, I got a lot of ros-humble-related updates.
After that, when I built autoware, I started getting the following errors.
Looking at the other files in autoware.universe, it seems that
tf2_eigen
is usually included in a single hierarchy.autoware.universe/localization/autoware_landmark_based_localizer/autoware_landmark_manager/src/landmark_manager.cpp
Line 22 in 7011ea1
https://github.com/search?q=repo%3Aautowarefoundation%2Fautoware.universe+%3Ctf2_eigen%2F&type=code
So the same change will be made to reaction_analyzer.
How was this PR tested?
I have confirmed that autoware can be built normally in the environment after the ros-humble update.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.