Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reaction_analyzer): fix include hierarchy of tf2_eigen #8663

Merged

Conversation

SakodaShintaro
Copy link
Contributor

Description

When I ran the following commands today, I got a lot of ros-humble-related updates.

sudo apt update
sudo apt -y upgrade

After that, when I built autoware, I started getting the following errors.

In file included from /home/shintarosakoda/autoware/src/universe/autoware.universe/tools/reaction_analyzer/include/reaction_analyzer_node.hpp:19,
                 from /home/shintarosakoda/autoware/src/universe/autoware.universe/tools/reaction_analyzer/src/reaction_analyzer_node.cpp:15:
/home/shintarosakoda/autoware/src/universe/autoware.universe/tools/reaction_analyzer/include/subscriber.hpp:19:10: fatal error: tf2_eigen/tf2_eigen/tf2_eigen.hpp: そのようなファイルやディレクトリはありません
   19 | #include <tf2_eigen/tf2_eigen/tf2_eigen.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [CMakeFiles/reaction_analyzer.dir/build.make:76: CMakeFiles/reaction_analyzer.dir/src/reaction_analyzer_node.cpp.o] エラー 1
gmake[2]: *** 未完了のジョブを待っています....
In file included from /home/shintarosakoda/autoware/src/universe/autoware.universe/tools/reaction_analyzer/src/subscriber.cpp:15:
/home/shintarosakoda/autoware/src/universe/autoware.universe/tools/reaction_analyzer/include/subscriber.hpp:19:10: fatal error: tf2_eigen/tf2_eigen/tf2_eigen.hpp: そのようなファイルやディレクトリはありません
   19 | #include <tf2_eigen/tf2_eigen/tf2_eigen.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Looking at the other files in autoware.universe, it seems that tf2_eigen is usually included in a single hierarchy.

https://github.com/search?q=repo%3Aautowarefoundation%2Fautoware.universe+%3Ctf2_eigen%2F&type=code

So the same change will be made to reaction_analyzer.

How was this PR tested?

I have confirmed that autoware can be built normally in the environment after the ros-humble update.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
@SakodaShintaro SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 28, 2024
@SakodaShintaro SakodaShintaro self-assigned this Aug 28, 2024
@github-actions github-actions bot added the component:tools Utility and debugging software. (auto-assigned) label Aug 28, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.16%. Comparing base (7011ea1) to head (6ee5288).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8663      +/-   ##
==========================================
- Coverage   24.17%   24.16%   -0.01%     
==========================================
  Files        1399     1400       +1     
  Lines      102129   102160      +31     
  Branches    38778    38782       +4     
==========================================
  Hits        24686    24686              
- Misses      74937    74968      +31     
  Partials     2506     2506              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 24.17% <ø> (ø) Carriedforward from 7011ea1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Aug 29, 2024
@SakodaShintaro SakodaShintaro marked this pull request as ready for review August 29, 2024 00:11
@takayuki5168
Copy link
Contributor

Let me merge this PR right now without @brkay54 's review since the build of awf/autoware is failing. Thank you.

@takayuki5168 takayuki5168 merged commit e679202 into autowarefoundation:main Aug 29, 2024
47 of 48 checks passed
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 29, 2024
…oundation#8663)

Fixed include hierarchy of tf2_eigen

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
rej55 added a commit to tier4/autoware.universe that referenced this pull request Aug 29, 2024
fix(reaction_analyzer): fix include hierarchy of tf2_eigen (autowarefoundation#8663)
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…oundation#8663)

Fixed include hierarchy of tf2_eigen

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
hayato-m126 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 5, 2024
…oundation#8663)

Fixed include hierarchy of tf2_eigen

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Naophis pushed a commit to tier4/autoware.universe that referenced this pull request Sep 6, 2024
…oundation#8663)

Fixed include hierarchy of tf2_eigen

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
MasatoSaeki pushed a commit to tier4/autoware.universe that referenced this pull request Sep 9, 2024
…oundation#8663)

Fixed include hierarchy of tf2_eigen

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Owen-Liuyuxuan pushed a commit to tier4/autoware.universe that referenced this pull request Sep 10, 2024
…oundation#8663)

Fixed include hierarchy of tf2_eigen

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Owen-Liuyuxuan pushed a commit to tier4/autoware.universe that referenced this pull request Sep 10, 2024
…oundation#8663)

Fixed include hierarchy of tf2_eigen

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…oundation#8663)

Fixed include hierarchy of tf2_eigen

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:tools Utility and debugging software. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants