fix(autoware_detected_object_validation): fix functionStatic

[kobayu858]

Description

This is a fix based on cppcheck functionStatic warnings

Since this function internally calls another function and updates member variables within it, it was decided that it would be better to call it using an instance. Therefore, I have suppressed the warning with a comment.

perception/autoware_detected_object_validation/src/obstacle_pointcloud/debugger.hpp:69:8: performance: inconclusive: Technically the member function 'autoware::detected_object_validation::obstacle_pointcloud::Debugger::addNeighborPointcloud' can be static (but you may consider moving to unnamed namespace). [functionStatic]
  void addNeighborPointcloud(const pcl::PointCloud<pcl::PointXY>::Ptr & input)
       ^

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.89%. Comparing base (3470824) to head (27a53f7).
Report is 11 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8482   +/-   ##
=======================================
  Coverage   23.89%   23.89%           
=======================================
  Files        1380     1381    +1     
  Lines      101835   101824   -11     
  Branches    38773    38767    -6     
=======================================
- Hits        24337    24335    -2     
+ Misses      75041    75025   -16     
- Partials     2457     2464    +7     

Flag	Coverage Δ		*Carryforward flag
differential	2.94% <ø> (?)
total	23.89% <ø> (-0.01%)	⬇️	Carriedforward from 9d522ea

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Shin-kyoto]

LGTM

• I confirmed that addNeighborPointcloud(const pcl::PointCloud<pcl::PointXY>::Ptr & input) calls the member function(addNeighborPointcloud(const pcl::PointCloud<pcl::PointXYZ>::Ptr & input), so addNeighborPointcloud(const pcl::PointCloud<pcl::PointXY>::Ptr & input) should not be static function.
• I confirmed that the content of this PR is good to merge.
• I did NOT check this PR by running autoware.