Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_probabilistic_occupancy_grid_map): fix uninitMemberVar #8333

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck uninitMemberVar warnings.

perception/autoware_probabilistic_occupancy_grid_map/lib/costmap_2d/occupancy_grid_map_fixed.cpp:79:5: warning: Member variable 'BinInfo::range' is not initialized in the constructor. [uninitMemberVar]
    BinInfo() = default;
    ^

perception/autoware_probabilistic_occupancy_grid_map/lib/costmap_2d/occupancy_grid_map_fixed.cpp:79:5: warning: Member variable 'BinInfo::wx' is not initialized in the constructor. [uninitMemberVar]
    BinInfo() = default;
    ^

perception/autoware_probabilistic_occupancy_grid_map/lib/costmap_2d/occupancy_grid_map_fixed.cpp:79:5: warning: Member variable 'BinInfo::wy' is not initialized in the constructor. [uninitMemberVar]
    BinInfo() = default;
    ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 2, 2024
@kobayu858 kobayu858 requested a review from veqcc August 2, 2024 07:43
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.18%. Comparing base (3d849e9) to head (484ac78).
Report is 976 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8333       +/-   ##
===========================================
- Coverage   15.09%   10.18%    -4.91%     
===========================================
  Files        1967      102     -1865     
  Lines      135941     6880   -129061     
  Branches    42122     1212    -40910     
===========================================
- Hits        20520      701    -19819     
+ Misses      92700     6070    -86630     
+ Partials    22721      109    -22612     
Flag Coverage Δ
differential 10.18% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobayu858 kobayu858 merged commit 0a0994c into autowarefoundation:main Aug 5, 2024
38 of 39 checks passed
@kobayu858 kobayu858 deleted the fix/cppcheck_uninitMemberVar_per-12 branch August 13, 2024 06:19
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…utowarefoundation#8333)

fix:uninitMemberVar

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants