fix(autoware_pointcloud_preprocessor): fix passedByValue

[kobayu858]

Description

This is a fix based on cppcheck passedByValue warnings

sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:1935:40: performance: inconclusive: Function parameter 'position' should be passed by const reference. [passedByValue]
  iterator emplace_hint(const_iterator position, Args &&... args)
                                       ^

sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:1954:39: performance: inconclusive: Function parameter 'hint' should be passed by const reference. [passedByValue]
  iterator try_emplace(const_iterator hint, const key_type & key, Args &&... args)
                                      ^

sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:1961:39: performance: inconclusive: Function parameter 'hint' should be passed by const reference. [passedByValue]
  iterator try_emplace(const_iterator hint, key_type && key, Args &&... args)
                                      ^

sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:1980:44: performance: inconclusive: Function parameter 'hint' should be passed by const reference. [passedByValue]
  iterator insert_or_assign(const_iterator hint, const key_type & key, Mapped && obj)
                                           ^

sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:1987:44: performance: inconclusive: Function parameter 'hint' should be passed by const reference. [passedByValue]
  iterator insert_or_assign(const_iterator hint, key_type && key, Mapped && obj)
                                           ^

sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:1999:34: performance: inconclusive: Function parameter 'hint' should be passed by const reference. [passedByValue]
  iterator insert(const_iterator hint, const value_type & keyval)
                                 ^

sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:2007:34: performance: inconclusive: Function parameter 'hint' should be passed by const reference. [passedByValue]
  iterator insert(const_iterator hint, value_type && keyval)
                                 ^

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.24%. Comparing base (6719f5f) to head (7155872).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8242      +/-   ##
==========================================
- Coverage   29.25%   29.24%   -0.01%     
==========================================
  Files        1600     1602       +2     
  Lines      117744   117784      +40     
  Branches    50716    50720       +4     
==========================================
+ Hits        34447    34448       +1     
- Misses      74072    74112      +40     
+ Partials     9225     9224       -1     

Flag	Coverage Δ		*Carryforward flag
differential	12.71% <ø> (?)
total	29.25% <ø> (ø)		Carriedforward from 6719f5f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[YoshiRi]

LGTM