Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_velocity_smoother): fix unusedVariable warning #7585

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 19, 2024

Description

This is a fix based on cppcheck unusedVariable warning

planning/autoware_velocity_smoother/src/trajectory_utils.cpp:303:46: style: Unused variable: state [unusedVariable]
  std::tuple<double, double, double, double> state;
                                             ^

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 19, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 19, 2024
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
LGTM

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.68%. Comparing base (507e3f4) to head (3d44b16).
Report is 60 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7585       +/-   ##
===========================================
+ Coverage   14.84%   17.68%    +2.83%     
===========================================
  Files        1999      484     -1515     
  Lines      139163    38573   -100590     
  Branches    43716    10979    -32737     
===========================================
- Hits        20661     6822    -13839     
+ Misses      95731    30785    -64946     
+ Partials    22771      966    -21805     
Flag Coverage Δ
differential 17.68% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc veqcc merged commit b284599 into autowarefoundation:main Jun 19, 2024
44 checks passed
@veqcc veqcc deleted the fix_autoware_velocity_smoother branch June 19, 2024 07:33
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…foundation#7585)

fix unusedVariable warning

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
fix unusedVariable warning

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants