fix(lane_change): fix state transition in lane change module #7436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
rej55
changed the title
rej55
force-pushed
the
fix/state_transition_lane_change
branch
from
dfd3309 to
30cd2bd
Compare
rej55
requested review from
kosuke55,
satoshi-ota,
shmpwk,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
rej55
force-pushed
the
fix/state_transition_lane_change
branch
from
a443644 to
fc437e1
Compare
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
rej55
force-pushed
the
fix/state_transition_lane_change
branch
from
fc437e1 to
e2021bb
Compare
rej55
added
the
run:build-and-test-differential
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* fix(lane_change): fix state transition in lane change module Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * fix(lane_change): remove overridden run() function Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * fix(lane_change): fix RTC safety status Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, lane change module sometimes can not transit from
RUNNINGstate.In this change, I fixed the state transition problem in the lane change module.
Furthermore, I fixed the state transition problem that it transits
FAILUREstate if the lane change module finishes aborting maneuver.Related links
Tests performed
TIER IV INTERNAL LINK
Notes for reviewers
Interface changes
Not applicable.
ROS Topic Changes
Not applicable.
ROS Parameter Changes
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.