Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk): add velocity factor when slowing down #6670

Merged

Conversation

maxime-clem
Copy link
Contributor

Description

add velocity factor when slowing down in the crosswalk module.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 22, 2024
@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 22, 2024
@maxime-clem maxime-clem enabled auto-merge (squash) March 22, 2024 08:05
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
@maxime-clem maxime-clem enabled auto-merge (squash) March 22, 2024 08:06
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (872cbdd) to head (bdd4bd9).
Report is 4 commits behind head on main.

Files Patch % Lines
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6670      +/-   ##
==========================================
- Coverage   14.78%   14.78%   -0.01%     
==========================================
  Files        1925     1925              
  Lines      132734   132740       +6     
  Branches    39529    39533       +4     
==========================================
  Hits        19625    19625              
- Misses      91137    91143       +6     
  Partials    21972    21972              
Flag Coverage Δ *Carryforward flag
differential 11.10% <0.00%> (?)
total 14.78% <ø> (ø) Carriedforward from 872cbdd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit 338aca7 into autowarefoundation:main Mar 22, 2024
24 of 28 checks passed
@maxime-clem maxime-clem deleted the crosswalk/velocity_factor branch March 22, 2024 14:24
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ation#6670)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants