fix(lane_change): consider max velocity during path planning #6615
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Mar 14, 2024 in 38s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method scene.cpp: NormalLaneChange::getLaneChangePaths 🔥
Annotations
Check notice on line 1 in planning/behavior_path_lane_change_module/src/scene.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 1653 to 1654, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check warning on line 1318 in planning/behavior_path_lane_change_module/src/scene.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
NormalLaneChange::getLaneChangePaths already has high cyclomatic complexity, and now it increases in Lines of Code from 252 to 253. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Loading