Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(probabilistic_occupancy_grid_map): fix robot_pose to refer base_link_frame #6485

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Feb 23, 2024

Description

As reported in https://github.com/orgs/autowarefoundation/discussions/4202#discussioncomment-8564823, we found probabilistic occupancy grid map is published not on the baes_link but on the raw pointcloud frame.

This PR fixes the issue.

Related links

https://github.com/orgs/autowarefoundation/discussions/4202#discussioncomment-8564823

Tests performed

@tseco15 Could you check this PR in your environment and check if the problem is fixed?

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 23, 2024
@tseco15
Copy link

tseco15 commented Feb 26, 2024

Hi,
I can confirm that the PR solves the problem. I have tested it in my environment, and the occuppancy_grid_map is now published in base_link frame.

@YoshiRi YoshiRi enabled auto-merge (squash) February 26, 2024 08:48
@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 14.98%. Comparing base (7938920) to head (73caf75).
Report is 46 commits behind head on main.

Files Patch % Lines
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6485   +/-   ##
=======================================
  Coverage   14.98%   14.98%           
=======================================
  Files        1839     1839           
  Lines      127213   127213           
  Branches    38132    38132           
=======================================
  Hits        19069    19069           
  Misses      86809    86809           
  Partials    21335    21335           
Flag Coverage Δ *Carryforward flag
differential 27.23% <0.00%> (?)
total 14.98% <ø> (+<0.01%) ⬆️ Carriedforward from 7938920

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YoshiRi YoshiRi merged commit 0dbe52e into autowarefoundation:main Feb 26, 2024
30 of 32 checks passed
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…ink_frame (autowarefoundation#6485)

fix: fix robot_pose to refer base_link_frame

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
YoshiRi added a commit to tier4/autoware.universe that referenced this pull request Mar 11, 2024
…ink_frame (autowarefoundation#6485)

fix: fix robot_pose to refer base_link_frame

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…ink_frame (#6485)

fix: fix robot_pose to refer base_link_frame

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@YoshiRi YoshiRi deleted the fix/fix_ogm_pose_origin branch April 1, 2024 01:33
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ink_frame (autowarefoundation#6485)

fix: fix robot_pose to refer base_link_frame

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants