-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): use different expected deceleration for bike/car #6328
feat(intersection): use different expected deceleration for bike/car #6328
Conversation
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6328 +/- ##
==========================================
- Coverage 14.90% 14.90% -0.01%
==========================================
Files 1817 1817
Lines 125466 125472 +6
Branches 37706 37710 +4
==========================================
Hits 18699 18699
- Misses 85751 85754 +3
- Partials 21016 21019 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…utowarefoundation#6328) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
feat(intersection): cherry-pick awf autowarefoundation#6328 + autowarefoundation#6299 + autowarefoundation#6325
…utowarefoundation#6328) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…utowarefoundation#6328) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…utowarefoundation#6328) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Description
use different expected deceleration for bike/car on amber/red traffic light
Related links
autowarefoundation/autoware_launch#852
https://tier4.atlassian.net/browse/RT1-4773
Tests performed
https://evaluation.tier4.jp/evaluation/reports/a40b1c77-0f2a-5017-95e8-f397bf4c3f25?project_id=prd_jt
at [00:12] intersection stop line is released
_decel4.0-2024-02-06_12.26.23.mp4
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.