Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): use different expected deceleration for bike/car #6328

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 6, 2024

Description

use different expected deceleration for bike/car on amber/red traffic light

Related links

autowarefoundation/autoware_launch#852

https://tier4.atlassian.net/browse/RT1-4773

Tests performed

https://evaluation.tier4.jp/evaluation/reports/a40b1c77-0f2a-5017-95e8-f397bf4c3f25?project_id=prd_jt

at [00:12] intersection stop line is released

_decel4.0-2024-02-06_12.26.23.mp4

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 6, 2024
@soblin soblin marked this pull request as ready for review February 6, 2024 03:46
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 6, 2024
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (0b90a97) 14.90% compared to head (7f12c7c) 14.90%.
Report is 8 commits behind head on main.

Files Patch % Lines
...avior_velocity_intersection_module/src/manager.cpp 0.00% 0 Missing and 5 partials ⚠️
...ection_module/src/scene_intersection_collision.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6328      +/-   ##
==========================================
- Coverage   14.90%   14.90%   -0.01%     
==========================================
  Files        1817     1817              
  Lines      125466   125472       +6     
  Branches    37706    37710       +4     
==========================================
  Hits        18699    18699              
- Misses      85751    85754       +3     
- Partials    21016    21019       +3     
Flag Coverage Δ *Carryforward flag
differential 4.62% <0.00%> (?)
total 14.90% <ø> (+<0.01%) ⬆️ Carriedforward from 0b90a97

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 9710828 into autowarefoundation:main Feb 7, 2024
30 of 35 checks passed
@soblin soblin deleted the feat/intersection/amber-red-ignore-bike-decel branch February 7, 2024 07:42
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 8, 2024
shmpwk added a commit to tier4/autoware.universe that referenced this pull request Feb 8, 2024
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants