chore(lidar_centerpoint): rework parameters #6167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <koji.minoda@tier4.jp>
kminoda
requested review from
knzo25,
yukke42,
miursh,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
component:perception
4 tasks
|
@kminoda Must update other parameter files in Web.Auto as well. |
Signed-off-by: kminoda <koji.minoda@tier4.jp>
kminoda
changed the title
yukkysaito
approved these changes
Jan 26, 2024
kminoda
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6167 +/- ##
==========================================
+ Coverage 14.36% 14.86% +0.49%
==========================================
Files 1907 1844 -63
Lines 130136 125804 -4332
Branches 37640 37582 -58
==========================================
- Hits 18697 18695 -2
+ Misses 90430 86099 -4331
- Partials 21009 21010 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
miursh
reviewed
Jan 29, 2024
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
github-actions
bot
added
the
type:documentation
kminoda
requested review from
amc-nu,
kyoichi-sugahara,
soblin,
shmpwk,
takayuki5168,
tkimura4,
badai-nguyen,
ktro2828,
tzhong518 and
anhnv3991
as code owners
YamatoAndo
requested review from
amc-nu,
anhnv3991,
takayuki5168,
soblin,
kyoichi-sugahara,
shmpwk,
mitsudome-r,
tzhong518 and
tkimura4
kminoda
removed request for
amc-nu,
anhnv3991,
takayuki5168,
soblin,
kyoichi-sugahara,
shmpwk,
mitsudome-r,
tzhong518 and
tkimura4
knzo25
reviewed
Feb 3, 2024
| <param from="$(var class_remapper_param_path)"/> | ||
|
|
||
| <!-- This parameter shall NOT be included in param file. See the PR from the git blame for details. --> |
There was a problem hiding this comment.
nit: in my experience it is customary to paste the link for the PR. this avoids cases where lints or similar change the blame content
|
@kminoda |
Signed-off-by: kminoda <koji.minoda@tier4.jp>
zulfaqar-azmi-t4
pushed a commit
to zulfaqar-azmi-t4/autoware.universe
that referenced
this pull request
Feb 6, 2024
* chore(lidar_centerpoint): use config Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert unnecessary fix Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix: revert build_only option Signed-off-by: kminoda <koji.minoda@tier4.jp> * docs: update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * fix: add pr url Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Feb 13, 2024
* chore(lidar_centerpoint): use config Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert unnecessary fix Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix: revert build_only option Signed-off-by: kminoda <koji.minoda@tier4.jp> * docs: update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * fix: add pr url Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
* chore(lidar_centerpoint): use config Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert unnecessary fix Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix: revert build_only option Signed-off-by: kminoda <koji.minoda@tier4.jp> * docs: update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * fix: add pr url Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use parameter instead of declaring individually in launch.xml.
Must be merged with autowarefoundation/autoware_launch#822
Tests performed
Confirmed that Autoware starts with
perception_mode:=lidar.Effects on system behavior
No effect expected
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.