refactor(external_velocity_limit_selector): rework parameter #5238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuqiHuai
requested review from
satoshi-ota,
0x126,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
type:documentation
satoshi-ota
approved these changes
Nov 22, 2023
satoshi-ota
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5238 +/- ##
==========================================
- Coverage 15.32% 14.77% -0.55%
==========================================
Files 1721 1648 -73
Lines 118559 114011 -4548
Branches 37995 35110 -2885
==========================================
- Hits 18169 16846 -1323
+ Misses 79657 78225 -1432
+ Partials 20733 18940 -1793
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuqi Huai <yhuai@uci.edu>
…ters Signed-off-by: Yuqi Huai <yhuai@uci.edu>
satoshi-ota
force-pushed
the
external_velocity_limit_selector
branch
from
9a6af70 to
376e8da
Compare
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…efoundation#5238) * refactor(external_velocity_limit_selector): rework parameter Signed-off-by: Yuqi Huai <yhuai@uci.edu> * style(pre-commit): autofix * doc(external_velocity_limit_selector): fix parameter file path * doc(external_velocity_limit_selector): fix default for numeric parameters Signed-off-by: Yuqi Huai <yhuai@uci.edu> --------- Signed-off-by: Yuqi Huai <yhuai@uci.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
rej55
added a commit
to rej55/autoware.universe
that referenced
this pull request
Jan 22, 2024
rej55
added a commit
that referenced
this pull request
Jan 22, 2024
rej55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 23, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)" This reverts commit 19dab56.
4 tasks
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 23, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)" This reverts commit 19dab56.
shmpwk
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 23, 2024
fix(external_velocity_limit_selector): revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)"
h-ohta
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 8, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)" This reverts commit 19dab56.
0x126
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 13, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) (#1135) Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)" This reverts commit 19dab56. Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
mergify bot
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 18, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) (#1135) Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)" This reverts commit 19dab56. Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> (cherry picked from commit 07e919b)
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)" This reverts commit 19dab56.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ROS node configuration refactored according to Guideline.
Related links
None.
Tests performed
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to external_velocity_limit_selectorros2 launch external_velocity_limit_selector external_velocity_limit_selector.launch.xmlNotes for reviewers
None.
Interface changes
config/external_velocity_limit_selector.param.yamlEffects on system behavior
None.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.