Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(safety_check): add hysteresis factor in safety check logic #4735

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Aug 24, 2023

Description

🤖 Generated by Copilot at de27076

Implemented a new hysteresis mechanism for the avoidance module in the behavior path planner. This mechanism uses a hysteresis_factor_safe_count and a hysteresis_factor_expand_rate to avoid switching paths too frequently and to adjust the safety margin for the collision check. Renamed and added parameters in avoidance.param.yaml and related files to reflect this change.

Tests performed

Effects on system behavior

improve avoidance safety check judgement

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 24, 2023
@satoshi-ota satoshi-ota force-pushed the feat/hysteresis-factor branch 2 times, most recently from 910a67e to de27076 Compare August 25, 2023 08:04
@satoshi-ota satoshi-ota marked this pull request as ready for review August 25, 2023 08:12
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 25, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super thanks so much for quick implemtentation!!!!!
LGTM

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 7.69% and project coverage change: -0.01% ⚠️

Comparison is base (febb7d5) 15.10% compared to head (da218af) 15.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4735      +/-   ##
==========================================
- Coverage   15.10%   15.10%   -0.01%     
==========================================
  Files        1563     1563              
  Lines      107946   107954       +8     
  Branches    33140    33143       +3     
==========================================
+ Hits        16303    16304       +1     
- Misses      73871    73877       +6     
- Partials    17772    17773       +1     
Flag Coverage Δ *Carryforward flag
differential 13.15% <7.69%> (?)
total 15.10% <ø> (+<0.01%) ⬆️ Carriedforward from febb7d5

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 7.81% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...ath_planner/src/scene_module/avoidance/manager.cpp 6.53% <0.00%> (-0.03%) ⬇️
...h_planner/src/scene_module/lane_change/manager.cpp 6.62% <0.00%> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 4.00% <ø> (ø)
...ehavior_path_planner/src/utils/avoidance/utils.cpp 9.55% <0.00%> (ø)
...ner/src/utils/path_safety_checker/safety_check.cpp 30.59% <0.00%> (-0.47%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 11.54% <20.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/hysteresis-factor branch from de27076 to 99f65b3 Compare August 26, 2023 08:25
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/hysteresis-factor branch from 99f65b3 to da218af Compare August 27, 2023 00:15
@satoshi-ota satoshi-ota merged commit a158461 into autowarefoundation:main Aug 27, 2023
@satoshi-ota satoshi-ota deleted the feat/hysteresis-factor branch August 27, 2023 12:50
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 28, 2023
…warefoundation#4735)

* feat(safety_check): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(lane_change): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): add time series hysteresis

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Sep 5, 2023
…warefoundation#4735)

* feat(safety_check): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(lane_change): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): add time series hysteresis

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Sep 11, 2023
…warefoundation#4735)

* feat(safety_check): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(lane_change): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): add time series hysteresis

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
…warefoundation#4735)

* feat(safety_check): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(lane_change): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): add time series hysteresis

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants