-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(safety_check): add hysteresis factor in safety check logic #4735
feat(safety_check): add hysteresis factor in safety check logic #4735
Conversation
910a67e
to
de27076
Compare
planning/behavior_path_planner/src/utils/path_safety_checker/safety_check.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super thanks so much for quick implemtentation!!!!!
LGTM
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4735 +/- ##
==========================================
- Coverage 15.10% 15.10% -0.01%
==========================================
Files 1563 1563
Lines 107946 107954 +8
Branches 33140 33143 +3
==========================================
+ Hits 16303 16304 +1
- Misses 73871 73877 +6
- Partials 17772 17773 +1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
de27076
to
99f65b3
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
99f65b3
to
da218af
Compare
…warefoundation#4735) * feat(safety_check): add hysteresis factor Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(lane_change): add hysteresis factor Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): add hysteresis factor Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): add time series hysteresis Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…warefoundation#4735) * feat(safety_check): add hysteresis factor Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(lane_change): add hysteresis factor Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): add hysteresis factor Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): add time series hysteresis Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…warefoundation#4735) * feat(safety_check): add hysteresis factor Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(lane_change): add hysteresis factor Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): add hysteresis factor Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): add time series hysteresis Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…warefoundation#4735) * feat(safety_check): add hysteresis factor Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(lane_change): add hysteresis factor Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): add hysteresis factor Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): add time series hysteresis Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
🤖 Generated by Copilot at de27076
Implemented a new hysteresis mechanism for the avoidance module in the behavior path planner. This mechanism uses a
hysteresis_factor_safe_count
and ahysteresis_factor_expand_rate
to avoid switching paths too frequently and to adjust the safety margin for the collision check. Renamed and added parameters inavoidance.param.yaml
and related files to reflect this change.Tests performed
Effects on system behavior
improve avoidance safety check judgement
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.