Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): use common logger #4072

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jun 25, 2023

Description

Refactor, defining a common logger.

Tests performed

build success

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 25, 2023
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7b6bff2) 14.37% compared to head (48b825f) 14.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4072   +/-   ##
=======================================
  Coverage   14.37%   14.37%           
=======================================
  Files        1566     1566           
  Lines      107726   107726           
  Branches    31175    31175           
=======================================
  Hits        15482    15482           
+ Misses      75420    75418    -2     
- Partials    16824    16826    +2     
Flag Coverage Δ *Carryforward flag
differential 13.63% <0.00%> (?)
total 14.37% <ø> (+<0.01%) ⬆️ Carriedforward from 7b6bff2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r_path_planner/scene_module/lane_change/normal.hpp 50.00% <ø> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 4.40% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe merged commit 40f9311 into autowarefoundation:main Jun 25, 2023
@TakaHoribe TakaHoribe deleted the refactor-lc-logger branch June 25, 2023 22:23
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 29, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 4, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 5, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
SaltUhey pushed a commit to SaltUhey/autoware.universe that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants