fix(tier4_perception_launch): fix duplicated topic name #3645
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
github-actions
bot
added
the
component:launch
badai-nguyen
requested review from
miursh,
YoshiRi,
yukkysaito and
a team
as code owners
miursh
reviewed
May 9, 2023
| @@ -230,7 +230,7 @@ | |||
| <include file="$(find-pkg-share object_merger)/launch/object_association_merger.launch.xml"> | |||
| <arg name="input/object0" value="$(var merger/input/objects)"/> | |||
| <arg name="input/object1" value="clustering/camera_lidar_fusion/objects"/> | |||
| <arg name="output/object" value="camera_lidar_fusion/objects"/> | |||
| <arg name="output/object" value="camera_lidar_fusion/objects_without_tracker"/> | |||
There was a problem hiding this comment.
How about "$(var lidar_detection_model)_cluster_fusion/objects"
There was a problem hiding this comment.
@miursh since it is result of roi, cluster and lidar_detection_model, so how about "$(var lidar_detection_model)_roi_cluster_fusion/objects"
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3645 +/- ##
==========================================
+ Coverage 13.82% 14.69% +0.87%
==========================================
Files 1395 1297 -98
Lines 98083 92234 -5849
Branches 29155 29155
==========================================
- Hits 13556 13555 -1
+ Misses 69872 64023 -5849
- Partials 14655 14656 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
badai-nguyen
added a commit
to badai-nguyen/autoware.universe
that referenced
this pull request
Jun 19, 2023
…dation#3645) * fix(tier4_perception_launch): fix dublicated topic name Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: rename topic Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
4 tasks
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 19, 2023
…dation#3645) (#586) * fix(tier4_perception_launch): fix dublicated topic name * chore: rename topic --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen
added a commit
to badai-nguyen/autoware.universe
that referenced
this pull request
Jun 21, 2023
…dation#3645) * fix(tier4_perception_launch): fix dublicated topic name Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: rename topic Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen
added a commit
to badai-nguyen/autoware.universe
that referenced
this pull request
Jun 29, 2023
…dation#3645) * fix(tier4_perception_launch): fix dublicated topic name Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: rename topic Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the duplicated name topics which are used in camera_lidar_radar_fusion mode.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.